fix #20564 Align behavior of ONNX Frontend function Relu-6, 13, 14 wi…

[Aryan8912]

close #20564

first I understand the difference between Relu 6, 13, and 14 and implement the here softmax.cpp then make a file relu6_13_14 and register a function [ops_bridge.cpp] …th original framework

Details:

• item1
• ...

Tickets:

• ticket-id

[p-wysocki]

build_jenkins

[p-wysocki]

Hi @Aryan8912, I see that there are no tests - could you please add them? That's the points 4, 5 and 6 in the Good First Issue description, "What needs to be done" section.

[gkrivor]

Let me do some clarifications. We already have a file https://github.com/openvinotoolkit/openvino/blob/master/src/frontends/onnx/frontend/src/op/relu.hpp with some "common implementation".

You may need to add a corresponding "relu.cpp" file. You need to move a function declaration there, and you need to leave only definition in a header. A moving all "inline" functions from headers is another part of refactoring.

And use the new relu.cpp to place declarations for new opsets there.

If you take a look in docs you will see, relu actually has version 1, 6, 13, 14, but actually it uses version 18... Version 18, as I saw previously, has just slightly different operations inside (uses operations from 18th opset). So we may not implement "version 18" at the moment.

As I can see, differences between versions are: 1 - 6 - lost a legacy attribute (which we actually didn't use (example: https://github.com/openvinotoolkit/openvino/blob/99d14a8b07a90f9328b208d8b881df84797b43fe/src/frontends/onnx/frontend/src/op/add.cpp#L18) 6-13 - extended list of supported input types (here is an example https://github.com/openvinotoolkit/openvino/blob/99d14a8b07a90f9328b208d8b881df84797b43fe/src/frontends/onnx/frontend/src/op/greater_or_equal.cpp#L22) 13-14 - extended list of supported input types

So, you will need to have 4 functions for 1-6, 6-13, 13-14, and 14+. Difference inside will be in an error messages depends on input types: tell user if it is using wrong combination of type-opset.

[Aryan8912]

please check my new update

[Aryan8912]

@gkrivor please check my PR update

[Aryan8912]

Sorry for the late reply sir, I just saw your comment, I am working on two issue right now so give some time I will update my code

[Aryan8912]

Hey sir, it is more than 5 days since I resubmitted my pull request, and there a no response, please if anything I missed please let me know.

[Aryan8912]

hey Sir, I have made a pull request , I am not able to understand what is the problem with this PR of mine. please help me out

[github-actions[bot]]

This PR will be closed in a week because of 2 weeks of no activity.

[Aryan8912]

No please don't close pr

[Aryan8912]

Can you tell me what type of changes need to be made in the code?

[github-actions[bot]]

This PR will be closed in a week because of 2 weeks of no activity.

[mlukasze]

hey @Aryan8912 will you have time to finish this PR?