open_model_zoo icon indicating copy to clipboard operation
open_model_zoo copied to clipboard

Published 20 hours ago • verified publisher icon openvinotoolkit

erfnet to omz

Open legendary111 opened this issue 3 years ago • 16 comments

Sorry,l have a question. Should i contribute new model to branch:master or branch:release2022.1?

legendary111 avatar Aug 11 '22 03:08 legendary111

accuracy-check ba713297e3b3d6e9400e9e1ab19781b 9976a557d80026d893315c852eefd1e

legendary111 avatar Aug 11 '22 03:08 legendary111

Sorry,l have a question. Should i contribute new model to branch:master or branch:release2022.1?

@legendary111 I believe master is the right place, release 2022.1 already published and branch used only for providing bugfixes for minor releases based on 2022.1

@yssemaev could you please review contribution from legal point of view?

eaidova avatar Aug 12 '22 04:08 eaidova

@eaidova @yssemaev Hello, I would like to know how long it will take to get the result?

legendary111 avatar Aug 16 '22 06:08 legendary111

Hi,

1.The erfnet_data is a part of the public dataset CULANE.CULane Dataset (xingangpan.github.io) And we belong to the school and want to contribute to the public model.

2.The author has added MIT license.

thanks,

Chuanqi

legendary111 avatar Aug 30 '22 01:08 legendary111

Hi Yuri,

Thanks for your guidance.

Initially we planned to use option 1 (public model). And use MIT license.

So in our case, no DSI is required.

Thanks,

Peng

legendary111 avatar Sep 05 '22 05:09 legendary111

@eaidova @yssemaev

legendary111 avatar Sep 05 '22 05:09 legendary111

The modification has been completed. Please check.

legendary111 avatar Sep 19 '22 11:09 legendary111

The demo is missing now

Wovchena avatar Sep 19 '22 11:09 Wovchena

Yes, I deleted it

legendary111 avatar Sep 19 '22 12:09 legendary111

Why? :) Every model in OMZ is required to be supported by at least one demo

Wovchena avatar Sep 19 '22 13:09 Wovchena

Image Segmentation Python* Demo can support erfnet model

legendary111 avatar Sep 20 '22 02:09 legendary111

Segmentatio-Results Image Segmentation Python* Demo test result

legendary111 avatar Sep 20 '22 03:09 legendary111

The modification has been completed. Please check.

legendary111 avatar Sep 20 '22 03:09 legendary111

The modification has been completed. Please check.

legendary111 avatar Sep 21 '22 02:09 legendary111

@legendary111 is it possible to modify files using code editor and repo code instead of uploading files via github web interface? https://www.atlassian.com/git here tutorials for it.

The reason why I ask, uploading files lead to wrong comments history and hard to review because it is not always treat modified files as the same and highlight changes, it is better practice to use git commits

eaidova avatar Sep 21 '22 04:09 eaidova

I'm sorry for the trouble caused by using the github web to upload files. Time is tight, and there shouldn't be much to revise. If I submit a PR next time, I will definitely use Git commit.

legendary111 avatar Sep 21 '22 09:09 legendary111

The modification has been completed. Please check.

legendary111 avatar Sep 25 '22 11:09 legendary111

Is there anything that needs to be modified later? If not, please approve the merging.

legendary111 avatar Oct 07 '22 06:10 legendary111

Hi! Is there anything that needs to be modified later?

legendary111 avatar Nov 13 '22 09:11 legendary111