ucx icon indicating copy to clipboard operation
ucx copied to clipboard

UCT/API/IB: Implement export/import mkey

Open dmitrygx opened this issue 3 years ago • 3 comments

What

Implement export/import mkey in IB transports.

Why ?

#8422 API changes have been merged, and IB export/import implementation could be added to expose XGVMI mkey. Alos, this PR has some API changes, since just noticed that it could be aligned with UCP APIs.

How ?

  1. Added new MD memory flag - UCT_MD_MEM_FLAG_EXPORT.
  2. Removed UCT_MD_MKEY_PACK_FLAG_EXPORT memory pack flag, UCT_MD_MEM_FLAG_EXPORT MD registration flag will be used instead.
  3. Add xgvmi implementation in IB transports to implement export/import API.

dmitrygx avatar Sep 14 '22 14:09 dmitrygx

@brminich @Artemy-Mellanox could you review pls?

dmitrygx avatar Sep 19 '22 05:09 dmitrygx

@dmitrygx seems you forgot to push

brminich avatar Sep 20 '22 10:09 brminich

@dmitrygx seems you forgot to push

@brminich yep, fixed

dmitrygx avatar Sep 20 '22 10:09 dmitrygx

@brminich replaced UCT_IB_MLX5_MD_TOKEN_SIZE by UCT_IB_MLX5DV_FLD_SZ_BYTES

dmitrygx avatar Sep 22 '22 11:09 dmitrygx

@yosefe could you review pls?

dmitrygx avatar Sep 22 '22 11:09 dmitrygx

@brminich could you re-approve pls? changes were squashed and moved the following code to the new place where cmd_hca_cap bits are valid (i.e. weren't filled by the next command): image

dmitrygx avatar Sep 25 '22 13:09 dmitrygx

/azp run

dmitrygx avatar Sep 25 '22 18:09 dmitrygx

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Sep 25 '22 18:09 azure-pipelines[bot]

@brminich could you review pls?

dmitrygx avatar Sep 26 '22 07:09 dmitrygx

@brminich @yosefe @Artemy-Mellanox could you review pls?

dmitrygx avatar Oct 05 '22 10:10 dmitrygx

@dmitrygx pls avoid force push during review

yosefe avatar Oct 05 '22 12:10 yosefe

@brminich could you review pls?

dmitrygx avatar Oct 05 '22 14:10 dmitrygx

@yosefe @brminich could you review pls?

dmitrygx avatar Oct 05 '22 17:10 dmitrygx

@yosefe @brminich squashed. could you reapprove pls?

dmitrygx avatar Oct 06 '22 08:10 dmitrygx