ucx icon indicating copy to clipboard operation
ucx copied to clipboard

UCP/WIREUP: Ensure doing KA for non-p2p lane when resolving ID

Open dmitrygx opened this issue 3 years ago • 2 comments

What

Ensure doing KA for non-p2p lane when resolving ID.

Why ?

In case of CONNECT_TO_WORKER and error-handling mode, UCP endpoint resolves EP ID and replaces UCT EP by Wireup EP. And if the lane is non-p2p (i.e. connected remotely as CONNECT_TO_IFACE), need to ensure that keepalive is done. If the lane is p2p, keepalive is done on auxiliary EP. (found during code review)

How ?

Update ucp_wireup_connect_remote to call ucp_wireup_ep_remote_connected for UCT EP if it is non-p2p lane.

dmitrygx avatar Apr 18 '22 14:04 dmitrygx

@hoopoepg @evgeny-leksikov could you review pls?

dmitrygx avatar Apr 20 '22 17:04 dmitrygx

@brminich could you review pls if have time?

dmitrygx avatar Jun 02 '22 07:06 dmitrygx