java-spring-jaeger icon indicating copy to clipboard operation
java-spring-jaeger copied to clipboard

Published 20 hours ago • verified publisher icon opentracing-contrib

Request: Upgade spring-cloud-starter version

Open magnuskvalheim opened this issue 4 years ago • 2 comments

Hi. There is a fix in recent spring-cloud-starter version for instrumenting kafka and @KafkaListeners. Would you consider upgrade 0.5.3 -> 0.5.9 (or greater) for next release?

For reference: https://github.com/opentracing-contrib/java-spring-cloud/pull/306/commits

magnuskvalheim avatar Mar 25 '21 14:03 magnuskvalheim

Definitely!

Would you like to submit a Pull Request updating the version?

geoand avatar Mar 26 '21 06:03 geoand

Hi @geoand . Sure - I created a PR: https://github.com/opentracing-contrib/java-spring-jaeger/pull/124

Locally, I couldnt get io.opentracing.contrib.java.spring.web.jaeger.starter.it.JaegerIntegrationTest to run. I have a docker on my dev machine though.

"Could not find a valid Docker environment. Please see logs and check configuration"

magnuskvalheim avatar Mar 31 '21 08:03 magnuskvalheim