subtensor icon indicating copy to clipboard operation
subtensor copied to clipboard

Feat/gov/subnet owners

Open camfairchild opened this issue 1 year ago • 0 comments

Description

Related Issue(s)

  • Closes #388

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update
  • [ ] Other (please describe):

Breaking Change

This change impacts the voting process for the Senate. Instead of using the subtensorModule.vote(...) call (now removed), Senate members should use governance.vote(..., group: Senate, ...)

This change also renames the Triumvirate (collective) pallet to Governance, which impacts calls.

TODO

  • [x] New SubnetOwners governance group
    • [x] Add group
    • [x] Auto-manage membership
    • [x] Allow group to vote
  • [ ] Custom origin for 'Council' including multiple groups
  • [ ] Rename the collective pallet to governance
    • [ ] Write migration
    • [x] change calls throughout runtime
  • [x] Allow voting from the collective pallet instead of subtensorModule
  • [x] Allow configurable (runtime upgrade) voting thresholds for each group
  • [ ] Add tests

Checklist

  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [x] I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

camfairchild avatar May 16 '24 01:05 camfairchild