fhircore
fhircore copied to clipboard
Fix Back Navigation for Same Fragment Launches
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes [link to issue]
Engineer Checklist
- [ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
- [ ] I have added any strings visible on UI components to the
strings.xmlfile - [ ] I have updated the CHANGELOG.md file for any notable changes to the codebase
- [ ] I have run
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guide - [ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
- [ ] I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.
Code Reviewer Checklist
- [ ] I have verified Unit tests have been written for any new feature(s) and edge cases
- [ ] I have verified any strings visible on UI components are in the
strings.xmlfile - [ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
- [ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
- [ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app
Codecov Report
:x: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 24.6%. Comparing base (aaebbb6) to head (8d608b3).
:warning: Report is 6 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...fhircore/quest/util/extensions/ConfigExtensions.kt | 0.0% | 10 Missing :warning: |
:x: Your patch status has failed because the patch coverage (0.0%) is below the target coverage (60.0%). You can increase the patch coverage or adjust the target coverage. :x: Your project status has failed because the head coverage (24.6%) is below the target coverage (25.0%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files
@@ Coverage Diff @@
## main #3755 +/- ##
=========================================
- Coverage 25.0% 24.6% -0.5%
- Complexity 844 849 +5
=========================================
Files 297 303 +6
Lines 16102 16478 +376
Branches 2689 2743 +54
=========================================
+ Hits 4038 4055 +17
- Misses 11580 11940 +360
+ Partials 484 483 -1
| Flag | Coverage Δ | |
|---|---|---|
| engine | 60.8% <ø> (-0.2%) |
:arrow_down: |
| geowidget | 21.7% <ø> (+3.1%) |
:arrow_up: |
| quest | 4.5% <0.0%> (-0.2%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...fhircore/quest/util/extensions/ConfigExtensions.kt | 0.0% <0.0%> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@qiarie could you fix the CI failures.