WebApp logging level select combobox does not affect internal logging level

[openshwprojects]

trafficstars

@btsimonh , is this intended?

EDIT: if you select DEBUG in App but have INFO in C code you still don't get debug logs. You must use "loglevel 4" comman.

[btsimonh]

I guess it's early code, before we changed some log filtering methods.

[iprak]

Would it make sense to limit logging for web on presence of an active connection ?

[openshwprojects]

I am not sure if I understand the question. I just think that changing LogLevel on WEB should send a "loglevel" command to device...

[iprak]

Never mind: Yes but I was thinking that that webApp is used to set the device and then probably never accessed. So logging into the buffer can be avoided. But we are just logging into a static buffer in cyclic manner so that cost is non-measurable. But I just realized that rowLog is fetched from webApp and not pushed so we are not just dumping log somewhere.

[iprak]

Since you are touching logging, do you recall if we need the semaphore in addLogAdv? Its status is not checked in that function. Same question for getData.

[iprak]

Are you sure this is a bug? When I select Log Level, I see matching commands being sent out.

I also noted Debug logging statements with Debug Log Level