splunk-forwarder-operator
splunk-forwarder-operator copied to clipboard
Revert proxy config changes
Reverting the proxy config changes to allow promoting https://github.com/openshift/splunk-forwarder-operator/pull/380
Codecov Report
:x: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 72.75%. Comparing base (c584b41) to head (b4cf3e2).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...lers/splunkforwarder/splunkforwarder_controller.go | 84.61% | 2 Missing :warning: |
| main.go | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #383 +/- ##
==========================================
- Coverage 73.59% 72.75% -0.84%
==========================================
Files 11 11
Lines 746 701 -45
==========================================
- Hits 549 510 -39
+ Misses 173 170 -3
+ Partials 24 21 -3
| Files with missing lines | Coverage Δ | |
|---|---|---|
| controllers/secret/secret_controller.go | 40.57% <100.00%> (-2.09%) |
:arrow_down: |
| pkg/kube/configmaps.go | 100.00% <100.00%> (+1.13%) |
:arrow_up: |
| pkg/kube/daemonset.go | 100.00% <100.00%> (ø) |
|
| pkg/kube/volumemounts.go | 100.00% <100.00%> (ø) |
|
| main.go | 0.00% <0.00%> (ø) |
|
| ...lers/splunkforwarder/splunkforwarder_controller.go | 46.39% <84.61%> (-1.19%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@typeid: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: typeid, wshearn
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [typeid,wshearn]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment