osdctl
osdctl copied to clipboard
openshift
OSD-22507: New IAM credential, secret rotate util
First pass at OSD-22507. Attempting to consolidate previous bash, osdctl, additional SOP steps to into a single command/context to help users rotate Osd Admin user(s)' IAM creds and related secrets.
To test... git clone [email protected]:nephomaniac/osdctl.git --branch OSD-22507-poc --single-branch --depth 1 osdctl_osd_22507 && cd osdctl_osd_22507
go build
./osdctl account iam-secret-mgmt -h
@nephomaniac: This pull request references OSD-22507 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
First pass at OSD-22507. Attempting to consolidate previous bash, osdctl, additional SOP steps to into a single command/context to help users rotate Osd Admin user(s)' IAM creds and related secrets.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Big thanks @iamkirkbater for the review and comments. Most recent commit should contain these suggestions as well as support -o yaml/json to stdout (logs to stderr) for the 'describe' specific commands.
@nephomaniac: This pull request references OSD-22507 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
First pass at OSD-22507. Attempting to consolidate previous bash, osdctl, additional SOP steps to into a single command/context to help users rotate Osd Admin user(s)' IAM creds and related secrets.
To test...
git clone [email protected]:nephomaniac/osdctl.git --branch [OSD-22507](https://issues.redhat.com//browse/OSD-22507)-poc --single-branch --depth 1 osdctl_osd_22507 && cd osdctl_osd_22507 go build ./osdctl account iam-secret-mgmt -h
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@nephomaniac: This pull request references OSD-22507 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
First pass at OSD-22507. Attempting to consolidate previous bash, osdctl, additional SOP steps to into a single command/context to help users rotate Osd Admin user(s)' IAM creds and related secrets.
To test...
git clone [email protected]:nephomaniac/osdctl.git --branch [OSD-22507](https://issues.redhat.com//browse/OSD-22507)-poc --single-branch --depth 1 osdctl_osd_22507 && cd osdctl_osd_22507 go build ./osdctl account iam-secret-mgmt -h
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@nephomaniac: This pull request references OSD-22507 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
First pass at OSD-22507. Attempting to consolidate previous bash, osdctl, additional SOP steps to into a single command/context to help users rotate Osd Admin user(s)' IAM creds and related secrets.
To test... `git clone [email protected]:nephomaniac/osdctl.git --branch OSD-22507-poc --single-branch --depth 1 osdctl_osd_22507 && cd osdctl_osd_22507
go build
./osdctl account iam-secret-mgmt -h`
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@nephomaniac: This pull request references OSD-22507 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
First pass at OSD-22507. Attempting to consolidate previous bash, osdctl, additional SOP steps to into a single command/context to help users rotate Osd Admin user(s)' IAM creds and related secrets.
To test... git clone [email protected]:nephomaniac/osdctl.git --branch OSD-22507-poc --single-branch --depth 1 osdctl_osd_22507 && cd osdctl_osd_22507
go build
./osdctl account iam-secret-mgmt -h
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@nephomaniac @clcollins Any further updates on this? Is this ready to go ahead
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nephomaniac Once this PR has been reviewed and has the lgtm label, please assign joshbranham for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@nephomaniac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/format | 354cbf663dc3957590403eb2175d1bb3273d462b | link | true | /test format |
| ci/prow/lint | 354cbf663dc3957590403eb2175d1bb3273d462b | link | true | /test lint |
| ci/prow/images | 354cbf663dc3957590403eb2175d1bb3273d462b | link | true | /test images |
| ci/prow/verify-docs | 354cbf663dc3957590403eb2175d1bb3273d462b | link | true | /test verify-docs |
| ci/prow/build | 354cbf663dc3957590403eb2175d1bb3273d462b | link | true | /test build |
| ci/prow/test | 354cbf663dc3957590403eb2175d1bb3273d462b | link | true | /test test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Given this PR >1 year old, has many changes, and a very long history of needing rebase, I am going to close it. I think if this work is to be carried forward, we should focus on making any refactoring needed to support the change in standalone PRs that we can review and merge in a timely manner, setting up the final "code changes" to be quick and simple to review. Reach out on slack if you want some help making this happen 👍
