origin
origin copied to clipboard
openshift
WRKLDS-1716: test/extended/cli: Drop oc serviceaccounts
oc serviceaccounts subcommand is deprecated, so the tests need to be aligned.
This is needed to unblock failing tests in https://github.com/openshift/oc/pull/2034
@tchap: This pull request references WRKLDS-1716 which is a valid jira issue.
In response to this:
The subcommand is being removed, so the tests are no longer needed. oc create token is now supposed to be used, which is just forwarding to kubectl create token, so there is nothing to test on our side.
This is needed to unblock failing tests in https://github.com/openshift/oc/pull/2034
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
oc create token is now supposed to be used, which is just forwarding to kubectl create token, so there is nothing to test on our side.
Conceptually you are right. But there is no test that exercises this upstream functionality against OCP cluster. Yes, we know that this works on vanilla Kubernetes. But we also have to know that oc create token works on OCP. So it is better to update our test to at least simply run create token.
@tchap: This pull request references WRKLDS-1716 which is a valid jira issue.
In response to this:
oc serviceaccountssubcommand is being removed, so the tests need to be aligned.This is needed to unblock failing tests in https://github.com/openshift/oc/pull/2034
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@tchap: This pull request references WRKLDS-1716 which is a valid jira issue.
In response to this:
oc serviceaccountssubcommand is deprecated, so the tests need to be aligned.This is needed to unblock failing tests in https://github.com/openshift/oc/pull/2034
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Job Failure Risk Analysis for sha: 20b26b1bc20a3a466c32a608a6e125dac594047c
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-main-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback | MissingData |
| pull-ci-openshift-origin-main-e2e-aws-disruptive | High [bz-Etcd] clusteroperator/etcd should not change condition/Available This test has passed 99.90% of 5885 runs on release 4.20 [Overall] in the last week. |
| pull-ci-openshift-origin-main-e2e-aws-ovn-etcd-scaling | Low [bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded This test has passed 50.00% of 2 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week. Open Bugs etcd-scaling jobs failing ~60% of the time |
| pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling | Medium [bz-OLM] clusteroperator/operator-lifecycle-manager-packageserver should not change condition/Available This test has passed 94.00% of 5885 runs on release 4.20 [Overall] in the last week. Open Bugs etcd-scaling jobs failing ~60% of the time |
| pull-ci-openshift-origin-main-e2e-gcp-csi | IncompleteTests Tests for this run (18) are below the historical average (1514): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-disruptive | IncompleteTests Tests for this run (19) are below the historical average (1275): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-ovn | IncompleteTests Tests for this run (19) are below the historical average (1232): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
![openshift-trt[bot] avatar](https://avatars.githubusercontent.com/u/111778100?v=4 "Published by a pub.dev verified publisher"){kind=small}
Job Failure Risk Analysis for sha: b0ff92db50fb02414359dd4c95a2b855a25dce97
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-main-e2e-aws | High [sig-cli] oc adm serviceaccounts [Suite:openshift/conformance/parallel] This test has passed 99.97% of 3179 runs on release 4.20 [Overall] in the last week. |
| pull-ci-openshift-origin-main-e2e-aws-ovn | High [sig-cli] oc adm serviceaccounts [Suite:openshift/conformance/parallel] This test has passed 99.97% of 3179 runs on release 4.20 [Overall] in the last week. |
| pull-ci-openshift-origin-main-e2e-aws-ovn-cgroupsv2 | High [sig-cli] oc adm serviceaccounts [Suite:openshift/conformance/parallel] This test has passed 99.97% of 3179 runs on release 4.20 [Overall] in the last week. |
| pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones | High [sig-cli] oc adm serviceaccounts [Suite:openshift/conformance/parallel] This test has passed 99.97% of 3179 runs on release 4.20 [Overall] in the last week. |
| pull-ci-openshift-origin-main-e2e-aws-ovn-etcd-scaling | Low [bz-kube-storage-version-migrator] clusteroperator/kube-storage-version-migrator should not change condition/Available This test has passed 74.46% of 5947 runs on release 4.20 [Overall] in the last week. Open Bugs [CI] e2e-openstack-ovn-etcd-scaling job permanent fails at many openshift-test tests etcd-scaling jobs failing ~60% of the time --- [bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded This test has passed 50.00% of 2 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week. Open Bugs etcd-scaling jobs failing ~60% of the time |
| pull-ci-openshift-origin-main-e2e-aws-ovn-microshift | High [sig-cli] oc adm serviceaccounts [Suite:openshift/conformance/parallel] This test has passed 99.97% of 3179 runs on release 4.20 [Overall] in the last week. |
| pull-ci-openshift-origin-main-e2e-aws-proxy | High [sig-cli] oc adm serviceaccounts [Suite:openshift/conformance/parallel] This test has passed 99.97% of 3179 runs on release 4.20 [Overall] in the last week. |
| pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling | Low [bz-kube-storage-version-migrator] clusteroperator/kube-storage-version-migrator should not change condition/Available This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week. Open Bugs [CI] e2e-openstack-ovn-etcd-scaling job permanent fails at many openshift-test tests etcd-scaling jobs failing ~60% of the time --- [bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week. Open Bugs etcd-scaling jobs failing ~60% of the time |
| pull-ci-openshift-origin-main-e2e-gcp-csi | IncompleteTests Tests for this run (19) are below the historical average (1147): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-disruptive | IncompleteTests Tests for this run (19) are below the historical average (956): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-fips-serial-1of2 | IncompleteTests Tests for this run (19) are below the historical average (1184): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-fips-serial-2of2 | IncompleteTests Tests for this run (18) are below the historical average (1208): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-ovn | IncompleteTests Tests for this run (19) are below the historical average (1604): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling | IncompleteTests Tests for this run (19) are below the historical average (1129): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-ovn-rt-upgrade | IncompleteTests Tests for this run (18) are below the historical average (1084): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade | IncompleteTests Tests for this run (19) are below the historical average (935): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-vsphere-ovn-etcd-scaling | Medium [sig-instrumentation] disruption/metrics-api connection/new should be available throughout the test Potential external regression detected for High Risk Test analysis |
Job Failure Risk Analysis for sha: 1d148d6b45b64ae05b879080dd4c4d9dc725f294
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-main-e2e-aws-ovn-etcd-scaling | Low [bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded This test has passed 50.00% of 2 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week. Open Bugs etcd-scaling jobs failing ~60% of the time |
| pull-ci-openshift-origin-main-e2e-gcp-csi | IncompleteTests Tests for this run (19) are below the historical average (903): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-disruptive | IncompleteTests Tests for this run (19) are below the historical average (754): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-fips-serial-1of2 | IncompleteTests Tests for this run (19) are below the historical average (950): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-fips-serial-2of2 | IncompleteTests Tests for this run (18) are below the historical average (975): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-ovn | IncompleteTests Tests for this run (18) are below the historical average (1709): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling | IncompleteTests Tests for this run (18) are below the historical average (900): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-ovn-rt-upgrade | IncompleteTests Tests for this run (18) are below the historical average (825): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade | IncompleteTests Tests for this run (19) are below the historical average (883): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
@tchap: This pull request references WRKLDS-1716 which is a valid jira issue.
In response to this:
This change is in preparation for removing
oc serviceaccounts.Related to https://github.com/openshift/oc/pull/2034
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@tchap: This pull request references WRKLDS-1716 which is a valid jira issue.
In response to this:
Extend tests related to
oc serviceaccounts. Originally I was planning to remove tests foroc serviceaccountsas I wanted to work on removing that group of deprecated subcommands, but I ended up postponing that. I still think we can merge the test change that extends the current tests to also checkoc create token.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@tchap: This pull request references WRKLDS-1716 which is a valid jira issue.
In response to this:
Originally I was planning to remove tests for
oc serviceaccountsas I wanted to work on removing that group of deprecated subcommands, but I ended up postponing that. I still think we can merge the test change that extends the current tests to also checkoc create tokenand remove the associatedTODOnotes.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@tchap: This pull request references WRKLDS-1716 which is a valid jira issue.
In response to this:
Originally I was planning to remove tests for
oc serviceaccountsas I wanted to work on removing that group of deprecated subcommands, but I ended up postponing that. I still think we can merge the test change that extends the current tests to also checkoc create tokenand remove the associatedTODOnotes.oc serviceaccountscalls can be removed later and the test added here kept in place.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ardaguclu, neisw, tchap
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [neisw]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/retest-required
Remaining retests: 0 against base HEAD 5be1d97706307eebf679dbfaaf2b041625a91a99 and 2 for PR HEAD de85e7445253cae2b7a772559cc25250cf8491f6 in total
/retest-required
Remaining retests: 0 against base HEAD cec622232fc8c85be494380ee644cf90447b530e and 1 for PR HEAD de85e7445253cae2b7a772559cc25250cf8491f6 in total
/retest-required
Remaining retests: 0 against base HEAD 205e55db3feafca6b56849aff1c267b72791a641 and 2 for PR HEAD de85e7445253cae2b7a772559cc25250cf8491f6 in total
/retest-required
Remaining retests: 0 against base HEAD fc0fc37f05bdea97ff8086c0de9724a8d65e34ef and 2 for PR HEAD de85e7445253cae2b7a772559cc25250cf8491f6 in total
@tchap: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback | 20b26b1bc20a3a466c32a608a6e125dac594047c | link | false | /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback |
| ci/prow/e2e-openstack-ovn | de85e7445253cae2b7a772559cc25250cf8491f6 | link | false | /test e2e-openstack-ovn |
| ci/prow/e2e-gcp-fips-serial-1of2 | de85e7445253cae2b7a772559cc25250cf8491f6 | link | false | /test e2e-gcp-fips-serial-1of2 |
| ci/prow/e2e-gcp-fips-serial-2of2 | de85e7445253cae2b7a772559cc25250cf8491f6 | link | false | /test e2e-gcp-fips-serial-2of2 |
| ci/prow/e2e-gcp-disruptive | de85e7445253cae2b7a772559cc25250cf8491f6 | link | false | /test e2e-gcp-disruptive |
| ci/prow/okd-e2e-gcp | de85e7445253cae2b7a772559cc25250cf8491f6 | link | false | /test okd-e2e-gcp |
| ci/prow/e2e-azure-ovn-upgrade | de85e7445253cae2b7a772559cc25250cf8491f6 | link | false | /test e2e-azure-ovn-upgrade |
| ci/prow/e2e-aws-ovn-etcd-scaling | de85e7445253cae2b7a772559cc25250cf8491f6 | link | false | /test e2e-aws-ovn-etcd-scaling |
| ci/prow/e2e-vsphere-ovn-etcd-scaling | de85e7445253cae2b7a772559cc25250cf8491f6 | link | false | /test e2e-vsphere-ovn-etcd-scaling |
| ci/prow/e2e-gcp-ovn-etcd-scaling | de85e7445253cae2b7a772559cc25250cf8491f6 | link | false | /test e2e-gcp-ovn-etcd-scaling |
| ci/prow/e2e-aws-ovn-single-node-upgrade | de85e7445253cae2b7a772559cc25250cf8491f6 | link | false | /test e2e-aws-ovn-single-node-upgrade |
| ci/prow/e2e-aws-disruptive | de85e7445253cae2b7a772559cc25250cf8491f6 | link | false | /test e2e-aws-disruptive |
| ci/prow/e2e-aws-ovn-serial-publicnet-1of2 | de85e7445253cae2b7a772559cc25250cf8491f6 | link | false | /test e2e-aws-ovn-serial-publicnet-1of2 |
| ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 | de85e7445253cae2b7a772559cc25250cf8491f6 | link | false | /test e2e-vsphere-ovn-dualstack-primaryv6 |
| ci/prow/e2e-azure-ovn-etcd-scaling | de85e7445253cae2b7a772559cc25250cf8491f6 | link | false | /test e2e-azure-ovn-etcd-scaling |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Job Failure Risk Analysis for sha: de85e7445253cae2b7a772559cc25250cf8491f6
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-main-e2e-aws-ovn-etcd-scaling | Low [bz-kube-storage-version-migrator] clusteroperator/kube-storage-version-migrator should not change condition/Available This test has passed 69.83% of 5440 runs on release 4.20 [Overall] in the last week. Open Bugs [CI] e2e-openstack-ovn-etcd-scaling job permanent fails at many openshift-test tests --- [bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded This test has passed 50.00% of 2 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week. |
| pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling | Low [bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week. |
| pull-ci-openshift-origin-main-e2e-azure-ovn-upgrade | Medium Job run should complete before timeout This test has passed 96.68% of 4305 runs on release 4.20 [Overall] in the last week. |
| pull-ci-openshift-origin-main-e2e-gcp-disruptive | IncompleteTests Tests for this run (104) are below the historical average (739): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
[ART PR BUILD NOTIFIER]
Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.20.0-202507041243.p0.ga2a0ef9.assembly.stream.el9. All builds following this will include this PR.
