origin icon indicating copy to clipboard operation
origin copied to clipboard

(olmv1) Refractor tests for better readability

Open anik120 opened this issue 6 months ago • 6 comments

Also get rid of "exponential backoff with jitter" usage in verifyAPIEndpoints and use an increased timeout of 2min for "pollUntilContextDeadline" instead.

anik120 avatar May 22 '25 14:05 anik120

Would it be possible to move these tests to their own file? I've been trying to organize things by file in this directory.

tmshort avatar May 22 '25 14:05 tmshort

@tmshort that's actually a great idea. Just pushed a change with a new file "olmv1-catalogd.go".

Note for reviewers who haven't seen the actual change, please see https://github.com/openshift/origin/pull/29840/commits/3b397899a42997d93ad84a9b98d0844f385dd05d for a better view of the actual changes, aside from the new file addition.

anik120 avatar May 22 '25 14:05 anik120

/retest

dtfranz avatar Jun 10 '25 05:06 dtfranz

/lgtm /approve

grokspawn avatar Jun 27 '25 18:06 grokspawn

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 27 '25 18:06 openshift-ci[bot]

@anik120: This pull request references OPRUN-3973 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Also get rid of "exponential backoff with jitter" usage in verifyAPIEndpoints and use an increased timeout of 2min for "pollUntilContextDeadline" instead.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 01 '25 15:07 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD 5be1d97706307eebf679dbfaaf2b041625a91a99 and 2 for PR HEAD 905d4356f970ac522b88d10b327013667ffbe4c6 in total

openshift-ci-robot avatar Jul 01 '25 19:07 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD cec622232fc8c85be494380ee644cf90447b530e and 1 for PR HEAD 905d4356f970ac522b88d10b327013667ffbe4c6 in total

openshift-ci-robot avatar Jul 02 '25 11:07 openshift-ci-robot

@anik120: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade 905d4356f970ac522b88d10b327013667ffbe4c6 link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-aws-disruptive 905d4356f970ac522b88d10b327013667ffbe4c6 link false /test e2e-aws-disruptive
ci/prow/e2e-aws-ovn-etcd-scaling 905d4356f970ac522b88d10b327013667ffbe4c6 link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-vsphere-ovn-etcd-scaling 905d4356f970ac522b88d10b327013667ffbe4c6 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial-1of2 905d4356f970ac522b88d10b327013667ffbe4c6 link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-gcp-ovn-etcd-scaling 905d4356f970ac522b88d10b327013667ffbe4c6 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-gcp-disruptive 905d4356f970ac522b88d10b327013667ffbe4c6 link false /test e2e-gcp-disruptive
ci/prow/e2e-gcp-fips-serial-2of2 905d4356f970ac522b88d10b327013667ffbe4c6 link false /test e2e-gcp-fips-serial-2of2
ci/prow/okd-e2e-gcp 905d4356f970ac522b88d10b327013667ffbe4c6 link false /test okd-e2e-gcp
ci/prow/e2e-aws-ovn-serial-publicnet-1of2 905d4356f970ac522b88d10b327013667ffbe4c6 link false /test e2e-aws-ovn-serial-publicnet-1of2
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 905d4356f970ac522b88d10b327013667ffbe4c6 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback 905d4356f970ac522b88d10b327013667ffbe4c6 link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-metal-ipi-serial-2of2 905d4356f970ac522b88d10b327013667ffbe4c6 link false /test e2e-metal-ipi-serial-2of2
ci/prow/e2e-azure-ovn-etcd-scaling 905d4356f970ac522b88d10b327013667ffbe4c6 link false /test e2e-azure-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 02 '25 18:07 openshift-ci[bot]

Job Failure Risk Analysis for sha: 905d4356f970ac522b88d10b327013667ffbe4c6

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-azure-ovn-upgrade Medium
Job run should complete before timeout
This test has passed 96.51% of 3980 runs on release 4.20 [Overall] in the last week.
pull-ci-openshift-origin-main-e2e-gcp-disruptive Medium
[bz-Etcd] clusteroperator/etcd should not change condition/Available
Potential external regression detected for High Risk Test analysis

openshift-trt[bot] avatar Jul 02 '25 18:07 openshift-trt[bot]

/retest-required

Remaining retests: 0 against base HEAD cec622232fc8c85be494380ee644cf90447b530e and 2 for PR HEAD 905d4356f970ac522b88d10b327013667ffbe4c6 in total

openshift-ci-robot avatar Jul 03 '25 11:07 openshift-ci-robot

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.20.0-202507031615.p0.g205e55d.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Jul 03 '25 17:07 openshift-bot