origin icon indicating copy to clipboard operation
origin copied to clipboard

Enforce consistent import ordering

Open stbenjam opened this issue 6 months ago • 6 comments

Introduces lint rules to enforce all Go imports are consistently ordered.

I ran golang-reviser to clean up the imports and group them logically.

stbenjam avatar May 14 '25 15:05 stbenjam

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar May 14 '25 15:05 openshift-ci[bot]

/test lint

stbenjam avatar May 14 '25 15:05 stbenjam

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 14 '25 15:05 openshift-ci[bot]

/test lint

stbenjam avatar May 14 '25 19:05 stbenjam

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar May 23 '25 09:05 openshift-merge-robot

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Aug 22 '25 01:08 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Sep 21 '25 08:09 openshift-bot

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-publicnet d0f3280cb815632c68ef4746a21263245d9a1785 link true /test e2e-aws-ovn-serial-publicnet
ci/prow/e2e-aws-csi d0f3280cb815632c68ef4746a21263245d9a1785 link true /test e2e-aws-csi
ci/prow/e2e-gcp-csi d0f3280cb815632c68ef4746a21263245d9a1785 link true /test e2e-gcp-csi
ci/prow/go-verify-deps d0f3280cb815632c68ef4746a21263245d9a1785 link true /test go-verify-deps
ci/prow/e2e-aws-ovn-microshift d0f3280cb815632c68ef4746a21263245d9a1785 link true /test e2e-aws-ovn-microshift
ci/prow/e2e-aws-ovn-microshift-serial d0f3280cb815632c68ef4746a21263245d9a1785 link true /test e2e-aws-ovn-microshift-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 04 '25 17:11 openshift-ci[bot]