origin icon indicating copy to clipboard operation
origin copied to clipboard

NE-1815: Adapt router metrics tests for DCM support

Open alebedev87 opened this issue 1 year ago • 10 comments

This PR follows up on a Dynamic Configuration Manager (DCM) gap identified during the smoke test.

When DCM is enabled by default, server management behavior changes. Not all servers will be in the UP state, and this must be accounted for in the router metrics tests. This PR updates the tests to handle scenarios where some servers may be DOWN. The scenarios when DCM is not enabled should still be working.

alebedev87 avatar Oct 10 '24 12:10 alebedev87

@alebedev87: This pull request references NE-1815 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

When the Dynamic Configuration Manager (DCM) is enabled by default, server management behavior changes. Not all servers will be in the UP state, and this must be accounted for in the router metrics tests. This commit updates the tests to handle scenarios where some servers may be DOWN.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 10 '24 12:10 openshift-ci-robot

Job Failure Risk Analysis for sha: fa18d0b5ecec5c03bf14abc6967ae994697e33a3

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout IncompleteTests
Tests for this run (101) are below the historical average (1163): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (14) are below the historical average (2200): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-trt-bot avatar Oct 10 '24 20:10 openshift-trt-bot

Job Failure Risk Analysis for sha: 7bb50cdc4aaca2e3d4806fe504216cfdc8dd24c7

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-serial High
[sig-api-machinery] disruption/oauth-api connection/new should be available throughout the test
This test has passed 100.00% of 52 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial'] in the last 14 days.
---
[sig-api-machinery] disruption/openshift-api connection/new should be available throughout the test
This test has passed 100.00% of 52 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial'] in the last 14 days.
---
[sig-api-machinery] disruption/kube-api connection/new should be available throughout the test
This test has passed 100.00% of 52 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial'] in the last 14 days.
---
[sig-api-machinery] disruption/cache-openshift-api connection/new should be available throughout the test
This test has passed 100.00% of 52 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial'] in the last 14 days.
---
Showing 4 of 7 test results

openshift-trt-bot avatar Oct 15 '24 19:10 openshift-trt-bot

@alebedev87: This pull request references NE-1815 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

When the Dynamic Configuration Manager (DCM) is enabled by default, server management behavior changes. Not all servers will be in the UP state, and this must be accounted for in the router metrics tests. This PR updates the tests to handle scenarios where some servers may be DOWN. The scenarios when DCM is not enabled should still be working.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 16 '24 12:10 openshift-ci-robot

/assign @gcs278

candita avatar Oct 16 '24 15:10 candita

Job Failure Risk Analysis for sha: c3e2a9f7968d34d83c7c850be87ea5d725495337

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Low
[bz-apiserver-auth] clusteroperator/authentication should not change condition/Available
This test has passed 0.00% of 64 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-single-node-serial'] in the last 14 days.

openshift-trt-bot avatar Oct 16 '24 16:10 openshift-trt-bot

@alebedev87: This pull request references NE-1815 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR follows up on the DCM gaps identified during the smoke test.

When the Dynamic Configuration Manager (DCM) is enabled by default, server management behavior changes. Not all servers will be in the UP state, and this must be accounted for in the router metrics tests. This PR updates the tests to handle scenarios where some servers may be DOWN. The scenarios when DCM is not enabled should still be working.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 16 '24 19:10 openshift-ci-robot

@alebedev87: This pull request references NE-1815 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR follows up on a Dynamic Configuration Manager (DCM) gap identified during the smoke test.

When DCM is enabled by default, server management behavior changes. Not all servers will be in the UP state, and this must be accounted for in the router metrics tests. This PR updates the tests to handle scenarios where some servers may be DOWN. The scenarios when DCM is not enabled should still be working.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 16 '24 19:10 openshift-ci-robot

/retest

alebedev87 avatar Oct 30 '24 09:10 alebedev87

@alebedev87: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-ipsec-serial fa18d0b5ecec5c03bf14abc6967ae994697e33a3 link false /test e2e-aws-ovn-ipsec-serial
ci/prow/e2e-aws-ovn-kube-apiserver-rollout c90f8c19d20a85c8e05b127f08b0881b0729cf18 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node-upgrade c90f8c19d20a85c8e05b127f08b0881b0729cf18 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 30 '24 13:10 openshift-ci[bot]

/lgtm

gcs278 avatar Oct 31 '24 15:10 gcs278

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, gcs278

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 31 '24 15:10 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD 6ce9801dc1b1d9e843bacddf325abfc0bf0d8b6e and 2 for PR HEAD c90f8c19d20a85c8e05b127f08b0881b0729cf18 in total

openshift-ci-robot avatar Oct 31 '24 18:10 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD 5e81bc269f767790a0a414a7473d95f60a73ebea and 1 for PR HEAD c90f8c19d20a85c8e05b127f08b0881b0729cf18 in total

openshift-ci-robot avatar Oct 31 '24 20:10 openshift-ci-robot

Job Failure Risk Analysis for sha: c90f8c19d20a85c8e05b127f08b0881b0729cf18

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout Low
[Conformance][Suite:openshift/kube-apiserver/rollout][Jira:"kube-apiserver"][sig-kube-apiserver] kube-apiserver should roll out new revisions without disruption [apigroup:config.openshift.io][apigroup:operator.openshift.io]
This test has passed 76.92% of 13 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-kube-apiserver-rollout'] in the last 14 days.

openshift-trt-bot avatar Nov 01 '24 03:11 openshift-trt-bot

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202411010937.p0.g8102da8.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Nov 01 '24 12:11 openshift-bot