origin icon indicating copy to clipboard operation
origin copied to clipboard

Omit etcds resource for HyperShift clusters

Open Evan-Reilly opened this issue 1 year ago • 5 comments

Related: https://github.com/openshift/hypershift/pull/3807#issuecomment-2341551844

Evan-Reilly avatar Sep 18 '24 19:09 Evan-Reilly

Hi @Evan-Reilly. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Sep 18 '24 20:09 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Evan-Reilly Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 18 '24 20:09 openshift-ci[bot]

/ok-to-test

rtheis avatar Sep 19 '24 10:09 rtheis

/retest-required

rtheis avatar Sep 19 '24 14:09 rtheis

@Evan-Reilly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-csi 691cda432d855ea6f3a3e818cd9bd5db6959f60b link false /test e2e-gcp-csi
ci/prow/e2e-metal-ipi-ovn 691cda432d855ea6f3a3e818cd9bd5db6959f60b link false /test e2e-metal-ipi-ovn
ci/prow/e2e-aws-ovn-upgrade 691cda432d855ea6f3a3e818cd9bd5db6959f60b link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-ipsec-serial 691cda432d855ea6f3a3e818cd9bd5db6959f60b link false /test e2e-aws-ovn-ipsec-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 691cda432d855ea6f3a3e818cd9bd5db6959f60b link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-ovn-builds 691cda432d855ea6f3a3e818cd9bd5db6959f60b link true /test e2e-gcp-ovn-builds

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 01 '24 22:10 openshift-ci[bot]

/hold since recent OCP conformance testing shows etcds resources now exist for HyperShift clusters at version 4.16 or later.

rtheis avatar Oct 21 '24 18:10 rtheis