origin
origin copied to clipboard
openshift
OCPBUGS-39000: add node-exporter to the list of default SCCs
The required-scc monitor test checks the list of default SCCs in order to determine whether the assigned SCC is custom or not; that list is missing the node-exporter SCC which means that the test will not suggest this to be pinned, as it thinks it is a custom one.
@liouk: This pull request references Jira Issue OCPBUGS-39000, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.18.0) matches configured target version for branch (4.18.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @xingxingxia
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
The required-scc monitor test checks the list of default SCCs in order to determine whether the assigned SCC is custom or not; that list is missing the
node-exporterSCC which means that the test will not suggest this to be pinned, as it thinks it is a custom one.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kramaranya, liouk Once this PR has been reviewed and has the lgtm label, please assign dennisperiquet for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Job Failure Risk Analysis for sha: 8c9da8bbcf1d99bb530dfe05e8fe8036b9afedf1
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade | Low [sig-cluster-lifecycle] pathological event should not see excessive Back-off restarting failed containers for ns/openshift-marketplace This test has passed 41.30% of 138 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week. |
We must stick to the kube-apiserver-operator's standard SCCs and avoid using node-exporter. This SCC comes from the monitoring operator and some clusters don't have monitoring, therefore it will be missing from those.
Closing.
/close
@liouk: Closed this PR.
In response to this:
We must stick to the kube-apiserver-operator's standard SCCs and avoid using node-exporter. This SCC comes from the monitoring operator and some clusters don't have monitoring, therefore it will be missing from those.
Closing.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@liouk: This pull request references Jira Issue OCPBUGS-39000. The bug has been updated to no longer refer to the pull request using the external bug tracker.
In response to this:
The required-scc monitor test checks the list of default SCCs in order to determine whether the assigned SCC is custom or not; that list is missing the
node-exporterSCC which means that the test will not suggest this to be pinned, as it thinks it is a custom one.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.