origin icon indicating copy to clipboard operation
origin copied to clipboard

[release-4.13] OCPBUGS-37921: Removes dependency on samples operator images

Open apoorvajagtap opened this issue 1 year ago • 10 comments
trafficstars

OpenShift-Samples operator still points to stale image versions. These non-existing image references lead to test-failures. This commit eliminates the dependency on samples operator for importing the ruby IS, and instead creates a custom ruby imageStream.

Manual cherry-pick of #28952 Tests in #28972 were failing due to inconsistent go version & method. Hence, a manual cherry-pick.

apoorvajagtap avatar Aug 14 '24 10:08 apoorvajagtap

@apoorvajagtap: This pull request references Jira Issue OCPBUGS-37921, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-36800 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-36800 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OpenShift-Samples operator still points to stale image versions. These non-existing image references lead to test-failures. This commit eliminates the dependency on samples operator for importing the ruby IS, and instead creates a custom ruby imageStream.

Manual cherry-pick of #28952 Tests in #28972 were failing due to inconsistent go version & method. Hence, a manual cherry-pick.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 14 '24 10:08 openshift-ci-robot

/retest-required

apoorvajagtap avatar Aug 26 '24 09:08 apoorvajagtap

/assign @adambkaplan @sayan-biswas

apoorvajagtap avatar Aug 26 '24 09:08 apoorvajagtap

/test e2e-gcp-ovn-builds

sayan-biswas avatar Aug 27 '24 11:08 sayan-biswas

/approve

sayan-biswas avatar Aug 27 '24 12:08 sayan-biswas

/lgtm

sayan-biswas avatar Aug 27 '24 12:08 sayan-biswas

/label backport-risk-assessed

sayan-biswas avatar Aug 27 '24 12:08 sayan-biswas

@sdodson can you please help with a review on this as well? Thanks!

apoorvajagtap avatar Aug 28 '24 06:08 apoorvajagtap

/retest

apoorvajagtap avatar Sep 02 '24 11:09 apoorvajagtap

@apoorvajagtap Do you know why the e2e-gcp-ovn-builds test is failing? Seems to be inability to clone a repo?

2024-09-02T12:26:02.709268579Z I0902 12:26:02.709214       1 scmauths.go:61] Finding auth for "..2024_09_02_12_26_01.1261125556"
2024-09-02T12:26:02.709268579Z I0902 12:26:02.709242       1 scmauths.go:61] Finding auth for "..data"
2024-09-02T12:26:02.709268579Z I0902 12:26:02.709251       1 scmauths.go:61] Finding auth for "password"
2024-09-02T12:26:02.709268579Z I0902 12:26:02.709258       1 scmauths.go:61] Found SCMAuth "password" to handle "password"
2024-09-02T12:26:02.709302652Z I0902 12:26:02.709266       1 scmauths.go:61] Finding auth for "username"
2024-09-02T12:26:02.709302652Z I0902 12:26:02.709274       1 scmauths.go:61] Found SCMAuth "password" to handle "username"
2024-09-02T12:26:02.709302652Z I0902 12:26:02.709283       1 scmauths.go:67] Setting up SCMAuth "password"
2024-09-02T12:26:02.709523195Z I0902 12:26:02.709481       1 scmauths.go:46] Adding username/password credentials to git config:
2024-09-02T12:26:02.709523195Z # credential git config
2024-09-02T12:26:02.709523195Z [credential]
2024-09-02T12:26:02.709523195Z    helper = store --file=/tmp/gitcredentials.120857910
2024-09-02T12:26:02.709523195Z 
2024-09-02T12:26:02.709795782Z Cloning "https://github.com/openshift-github-testing/nodejs-ex-private.git" ...
2024-09-02T12:26:02.709795782Z I0902 12:26:02.709782       1 source.go:237] git ls-remote --heads https://github.com/openshift-github-testing/nodejs-ex-private.git
2024-09-02T12:26:02.709854100Z I0902 12:26:02.709839       1 repository.go:450] Executing git ls-remote --heads https://github.com/openshift-github-testing/nodejs-ex-private.git
2024-09-02T12:26:02.926281370Z I0902 12:26:02.926221       1 repository.go:541] Error executing command: exit status 128
2024-09-02T12:26:02.926331120Z I0902 12:26:02.926313       1 source.go:237] remote: Invalid username or password.
2024-09-02T12:26:02.926331120Z fatal: Authentication failed for 'https://github.com/openshift-github-testing/nodejs-ex-private.git/'
2024-09-02T12:26:02.969100890Z error: failed to fetch requested repository "https://github.com/openshift-github-testing/nodejs-ex-private.git" with provided credentials

Does that need to be fixed separately?

sdodson avatar Sep 03 '24 19:09 sdodson

Yes, this is most likely an issue with the private git repo (OCPBUGS-37799). We'll be raising another PR to fix the gitauth.go failures.

apoorvajagtap avatar Sep 04 '24 06:09 apoorvajagtap

/override ci/prow/e2e-gcp-ovn-builds

sdodson avatar Sep 04 '24 13:09 sdodson

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-gcp-ovn-builds

In response to this:

/override ci/prow/e2e-gcp-ovn-builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Sep 04 '24 13:09 openshift-ci[bot]

@apoorvajagtap: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 04 '24 13:09 openshift-ci[bot]

@apoorvajagtap: Jira Issue OCPBUGS-37921: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37921 has been moved to the MODIFIED state.

In response to this:

OpenShift-Samples operator still points to stale image versions. These non-existing image references lead to test-failures. This commit eliminates the dependency on samples operator for importing the ruby IS, and instead creates a custom ruby imageStream.

Manual cherry-pick of #28952 Tests in #28972 were failing due to inconsistent go version & method. Hence, a manual cherry-pick.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 04 '24 13:09 openshift-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: apoorvajagtap, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 04 '24 13:09 openshift-ci[bot]

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.13.0-202409041408.p0.g19f8094.assembly.stream.el8. All builds following this will include this PR.

openshift-bot avatar Sep 04 '24 15:09 openshift-bot

Fix included in accepted release 4.13.0-0.nightly-2024-09-04-192748

openshift-merge-robot avatar Sep 05 '24 02:09 openshift-merge-robot

/cherrypick release-4.12

apoorvajagtap avatar Sep 10 '24 08:09 apoorvajagtap

@apoorvajagtap: new pull request created: #29080

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.