origin
origin copied to clipboard
openshift
CNF-8553: add a test for applying the firewall by the commatrix that created by the endpointslice and make sure that will not affect the behavior of the cluster
add a test for applying the firewall by the commatrix that created by the endpointslice and make sure that will not affect the behavior of the cluster jira link https://issues.redhat.com/browse/CNF-8553
Hi @aabughosh. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
administrative:
- looks like you at least need to run
hack/update-generated.shto update generated tests. - could you link a jira or other justification?
- could changes be consolidated into one or a few commits?
content concerns:
- are all the dependency updates really necessary?
- is there not already a function like
isSNOCluster? - this sets up a firewall, should it not also tear it down at some point?
- should this make an exclusion for microshift which lacks the infrastructure api?
- could changes be consolidat are all the dependency updates really necessary? i need the commatrix repo i ran go mod vendor is there not already a function like isSNOCluster? i didnt check the code but i created mine this sets up a firewall, should it not also tear it down at some point? thats test adding all the used ports to the nft table and drop the other, first we are seeing all the used ones by the endpointslice resource should this make an exclusion for microshift which lacks the infrastructure api? mm im not sure
Job Failure Risk Analysis for sha: 7b9c174911240e864b47f3830b49f358061fb8f6
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade | Medium [sig-network] pods should successfully create sandboxes by adding pod to network This test has passed 95.33% of 5096 runs on release 4.17 [Overall] in the last week. Open Bugs s390x: [sig-network] pods should successfully create sandboxes by adding pod to network fails with error adding pod to CNI network High rate of pod sandbox errors detected on metal |
@aabughosh: This pull request references CNF-8553 which is a valid jira issue.
In response to this:
add a test for applying the firewall by the commatrix that created by the endpointslice and make sure that will not affect the behavior of the cluster jira link https://issues.redhat.com/browse/CNF-8553
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Job Failure Risk Analysis for sha: 4c3aa021433abcaa9d29112fd4504b3026dd5f63
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial | IncompleteTests Tests for this run (26) are below the historical average (499): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: aabughosh, sosiouxme
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [sosiouxme]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Job Failure Risk Analysis for sha: 3a97a87d1e3fc443ab6edffd5d1549671711347b
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial | IncompleteTests Tests for this run (27) are below the historical average (513): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
Job Failure Risk Analysis for sha: bc5f243b237fbadf9eb784519d137658129fc0b7
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-master-e2e-openstack-ovn | IncompleteTests Tests for this run (17) are below the historical average (1804): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial | Medium [bz-openshift-apiserver] clusteroperator/openshift-apiserver should not change condition/Available This test has passed 92.60% of 1135 runs on release 4.18 [Overall] in the last week. |
Job Failure Risk Analysis for sha: 378a78ce20062269ea6d675126f8637f6e7d5dd1
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-master-e2e-openstack-ovn | IncompleteTests Tests for this run (18) are below the historical average (1754): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade | IncompleteTests Tests for this run (14) are below the historical average (850): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-gcp-ovn | IncompleteTests Tests for this run (14) are below the historical average (2064): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd | IncompleteTests Tests for this run (14) are below the historical average (885): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
Job Failure Risk Analysis for sha: 094cbcedd834442a7eb7ddb86792f913d2589eb3
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout | IncompleteTests Tests for this run (100) are below the historical average (195): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout | IncompleteTests Tests for this run (102) are below the historical average (143): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones | IncompleteTests Tests for this run (101) are below the historical average (1637): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-ovn-kubevirt | Medium [sig-sippy] infrastructure should work This test has passed 87.19% of 1788 runs on release 4.18 [Overall] in the last week. |
| pull-ci-openshift-origin-master-e2e-baremetalds-kubevirt | Low [sig-sippy] infrastructure should work This test has passed 0.00% of 1 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:sdn NetworkStack:ipv4 Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week. |
Job Failure Risk Analysis for sha: 12af59f850b0f08c635fc3c4f5b3040ac8bb03ff
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout | IncompleteTests Tests for this run (100) are below the historical average (184): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones | IncompleteTests Tests for this run (100) are below the historical average (1587): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-baremetalds-kubevirt | Medium [sig-sippy] infrastructure should work This test has passed 87.65% of 1984 runs on release 4.18 [Overall] in the last week. |
| pull-ci-openshift-origin-master-e2e-aws-ovn-kubevirt | Medium [sig-sippy] infrastructure should work This test has passed 87.65% of 1984 runs on release 4.18 [Overall] in the last week. |
@aabughosh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-ovn-kubevirt | 813a4e533f133a400ba7ad67dfac5030b74b4528 | link | false | /test e2e-aws-ovn-kubevirt |
| ci/prow/e2e-aws-ovn-kube-apiserver-rollout | 019928f91f63407e065f641808f6ce1f17297fb9 | link | false | /test e2e-aws-ovn-kube-apiserver-rollout |
| ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout | 019928f91f63407e065f641808f6ce1f17297fb9 | link | false | /test e2e-metal-ipi-ovn-kube-apiserver-rollout |
| ci/prow/e2e-baremetalds-kubevirt | 813a4e533f133a400ba7ad67dfac5030b74b4528 | link | false | /test e2e-baremetalds-kubevirt |
| ci/prow/e2e-aws-ovn-single-node-upgrade | 019928f91f63407e065f641808f6ce1f17297fb9 | link | false | /test e2e-aws-ovn-single-node-upgrade |
| ci/prow/e2e-aws-ovn-ipsec-serial | 019928f91f63407e065f641808f6ce1f17297fb9 | link | false | /test e2e-aws-ovn-ipsec-serial |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Job Failure Risk Analysis for sha: 019928f91f63407e065f641808f6ce1f17297fb9
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout | IncompleteTests Tests for this run (100) are below the historical average (169): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-baremetalds-kubevirt | Medium [sig-sippy] infrastructure should work This test has passed 87.93% of 2162 runs on release 4.18 [Overall] in the last week. |
| pull-ci-openshift-origin-master-e2e-aws-ovn-kubevirt | Medium [sig-sippy] infrastructure should work This test has passed 87.93% of 2162 runs on release 4.18 [Overall] in the last week. |