origin
origin copied to clipboard
openshift
HOSTEDCP-1466: test/ginkgo: allow many external binaries
Not only do we ultimately need to support external binaries from more than one image in the payload, we also need to support repositories that use go test for their end-to-end tests along with the old-school Ginkgo approach.
/assign @soltysh /cc @deads2k
@stevekuznetsov: This pull request references HOSTEDCP-1466 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Not only do we ultimately need to support external binaries from more than one image in the payload, we also need to support repositories that use
go testfor their end-to-end tests along with the old-school Ginkgo approach./assign @soltysh /cc @deads2k
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: stevekuznetsov Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@stevekuznetsov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-ovn-single-node-serial | cb40f1902a2b6eb2fdd5e0ddc1fab35ae43da9c6 | link | false | /test e2e-aws-ovn-single-node-serial |
| ci/prow/e2e-metal-ipi-sdn | cb40f1902a2b6eb2fdd5e0ddc1fab35ae43da9c6 | link | false | /test e2e-metal-ipi-sdn |
| ci/prow/e2e-aws-ovn-single-node-upgrade | cb40f1902a2b6eb2fdd5e0ddc1fab35ae43da9c6 | link | false | /test e2e-aws-ovn-single-node-upgrade |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@stevekuznetsov: Closed this PR.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
