origin
origin copied to clipboard
openshift
Request Headers: Change wait logic, add more debugging data to post mortem
What
- Reuse util solution, rather than custom logic
- Add more information to state-of-the-cluster during test run and especially on failure
Why
We are trying to identify the reason for the flakiness of the request headers idp test suite.
Ref
https://github.com/openshift/origin/pull/27194
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ibihim
To complete the pull request process, please assign danwinship after the PR has been reviewed.
You can assign the PR to them by writing /assign @danwinship in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
is this blocked on https://github.com/openshift/cluster-authentication-operator/pull/576?
@deads2k, it isn't blocked. It adds your changes and detailed logging on the assumed issue.
I also added some g.By's as per documentation it should help to create some milestones that help us understand the progress of the test and failures within it.
I also moved some code pieces that grew organically.
@ibihim: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-single-node-upgrade | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | false | /test e2e-aws-single-node-upgrade |
| ci/prow/e2e-aws-single-node | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | false | /test e2e-aws-single-node |
| ci/prow/e2e-gcp-csi | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | false | /test e2e-gcp-csi |
| ci/prow/e2e-aws-cgroupsv2 | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | false | /test e2e-aws-cgroupsv2 |
| ci/prow/e2e-metal-ipi-ovn-ipv6 | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | false | /test e2e-metal-ipi-ovn-ipv6 |
| ci/prow/e2e-aws-csi | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | false | /test e2e-aws-csi |
| ci/prow/e2e-aws-ovn-fips | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | true | /test e2e-aws-ovn-fips |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@ibihim: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@ibihim: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-single-node-upgrade | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | false | /test e2e-aws-single-node-upgrade |
| ci/prow/e2e-aws-single-node | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | false | /test e2e-aws-single-node |
| ci/prow/e2e-gcp-csi | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | false | /test e2e-gcp-csi |
| ci/prow/e2e-aws-cgroupsv2 | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | false | /test e2e-aws-cgroupsv2 |
| ci/prow/e2e-metal-ipi-ovn-ipv6 | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | false | /test e2e-metal-ipi-ovn-ipv6 |
| ci/prow/e2e-aws-csi | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | false | /test e2e-aws-csi |
| ci/prow/e2e-aws-ovn-fips | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | true | /test e2e-aws-ovn-fips |
| ci/prow/unit | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | true | /test unit |
| ci/prow/e2e-gcp-ovn-builds | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | true | /test e2e-gcp-ovn-builds |
| ci/prow/e2e-aws-ovn-image-registry | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | true | /test e2e-aws-ovn-image-registry |
| ci/prow/e2e-gcp-ovn-image-ecosystem | 2ece9f549d1410f56c95b6eaa868d8cfb53a2b40 | link | true | /test e2e-gcp-ovn-image-ecosystem |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.