origin icon indicating copy to clipboard operation
origin copied to clipboard

clean up logic for waiting authentication operator to finish progressing

Open deads2k opened this issue 3 years ago • 7 comments

I happened to need a general method for networking. See if this looks roughly equivalent.

/assign @ibihim

deads2k avatar May 31 '22 15:05 deads2k

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 31 '22 15:05 openshift-ci[bot]

/retest

deads2k avatar May 31 '22 20:05 deads2k

Having a general solution is super cool and I am wondering that we don't have something like that in place already.

One of our assumptions was that the inertia logic, that is set to up to 30 minutes for degraded in CAO was one of the causes for issues. You don't think that this is not the root cause?

ibihim avatar Jun 01 '22 13:06 ibihim

/retest

deads2k avatar Jun 01 '22 15:06 deads2k

One of our assumptions was that the inertia logic, that is set to up to 30 minutes for degraded in CAO was one of the causes for issues. You don't think that this is not the root cause?

Just looking to make a general "wait for this operator" because networking needed it and I think so did the vertical etcd scaling test.

deads2k avatar Jun 01 '22 15:06 deads2k

/retest

deads2k avatar Jun 01 '22 19:06 deads2k

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node-upgrade 60353b1627e25244746e7c0e968bd0e8e0c50826 link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-gcp-upgrade 60353b1627e25244746e7c0e968bd0e8e0c50826 link true /test e2e-gcp-upgrade
ci/prow/e2e-aws-single-node 60353b1627e25244746e7c0e968bd0e8e0c50826 link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 01 '22 23:06 openshift-ci[bot]

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node-upgrade 60353b1627e25244746e7c0e968bd0e8e0c50826 link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-gcp-upgrade 60353b1627e25244746e7c0e968bd0e8e0c50826 link true /test e2e-gcp-upgrade
ci/prow/e2e-aws-single-node 60353b1627e25244746e7c0e968bd0e8e0c50826 link false /test e2e-aws-single-node
ci/prow/e2e-gcp-ovn-image-ecosystem 60353b1627e25244746e7c0e968bd0e8e0c50826 link true /test e2e-gcp-ovn-image-ecosystem

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 05 '22 00:11 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Feb 04 '23 01:02 openshift-bot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Feb 04 '23 01:02 openshift-merge-robot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Mar 06 '23 08:03 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Apr 06 '23 00:04 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 06 '23 00:04 openshift-ci[bot]