openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OSDOCS-12297:Added WIF as auth type in create cluster on GCP workflow.

Open AedinC opened this issue 1 year ago • 14 comments
trafficstars

This PR adds information about WIF as an authentication type for GCP with CCS clusters. It also refreshes some other parts of the docs so that they are up to date with the current UI design.

Version(s): 4.17+

Issue: OSDOCS-12297

Link to docs preview:

Peer review:

  • [x] Peer reviewer has approved this change.

SME review:

  • [x] SME has approved this change.

QE review:

  • [x] QE has approved this change.

Additional information:

AedinC avatar Oct 16 '24 07:10 AedinC

@AedinC: This pull request references OSDOCS-12297 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Version(s): 4.17+

Issue: OSDOCS-12297

Link to docs preview:

Peer review:

  • [ ] Peer reviewer has approved this change.

SME review:

  • [ ] SME has approved this change.

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 16 '24 07:10 openshift-ci-robot

🤖 Mon Oct 21 16:12:05 - Prow CI generated the docs preview:

https://83595--ocpdocs-pr.netlify.app/openshift-dedicated/latest/osd_install_access_delete_cluster/creating-a-gcp-cluster.html https://83595--ocpdocs-pr.netlify.app/openshift-dedicated/latest/osd_install_access_delete_cluster/creating-an-aws-cluster.html

ocpdocs-previewbot avatar Oct 16 '24 08:10 ocpdocs-previewbot

@AedinC: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s): 4.17+

Issue: OSDOCS-12297

Link to docs preview:

Peer review:

  • [ ] Peer reviewer has approved this change.

SME review:

  • [ ] SME has approved this change.

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 16 '24 08:10 openshift-ci-robot

@AedinC: This pull request references OSDOCS-12297 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Version(s): 4.17+

Issue: OSDOCS-12297

Link to docs preview:

Peer review:

  • [ ] Peer reviewer has approved this change.

SME review:

  • [ ] SME has approved this change.

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 16 '24 09:10 openshift-ci-robot

@AedinC: This pull request references OSDOCS-12297 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR adds information about WIF as an authentication type for GCP with CCS clusters. It also refreshes some other parts of the docs so that they are up to date with the current UI design.

Version(s): 4.17+

Issue: OSDOCS-12297

Link to docs preview:

Peer review:

  • [ ] Peer reviewer has approved this change.

SME review:

  • [ ] SME has approved this change.

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 16 '24 14:10 openshift-ci-robot

Other than suggestion about changing WIF command to match what is in UI, looks good to me!

mletalie avatar Oct 17 '24 13:10 mletalie

/retest

AedinC avatar Oct 17 '24 13:10 AedinC

@AedinC: This pull request references OSDOCS-12297 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR adds information about WIF as an authentication type for GCP with CCS clusters. It also refreshes some other parts of the docs so that they are up to date with the current UI design.

Version(s): 4.17+

Issue: OSDOCS-12297

Link to docs preview:

Peer review:

  • [x] Peer reviewer has approved this change.

SME review:

  • [ ] SME has approved this change.

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 17 '24 14:10 openshift-ci-robot

@AedinC: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 21 '24 16:10 openshift-ci[bot]

@lento-sun Can you please provide a QE review for this when you get a chance? Many thanks.

AedinC avatar Oct 22 '24 08:10 AedinC

Hi @jloss-redhat would you be able to provide a QE review for this PR please?

AedinC avatar Oct 23 '24 12:10 AedinC

/lgtm

jloss-redhat avatar Oct 23 '24 15:10 jloss-redhat

Thanks @jloss-redhat!

AedinC avatar Oct 25 '24 07:10 AedinC

@AedinC: This pull request references OSDOCS-12297 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR adds information about WIF as an authentication type for GCP with CCS clusters. It also refreshes some other parts of the docs so that they are up to date with the current UI design.

Version(s): 4.17+

Issue: OSDOCS-12297

Link to docs preview:

Peer review:

  • [x] Peer reviewer has approved this change.

SME review:

  • [x] SME has approved this change.

QE review:

  • [x] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 25 '24 07:10 openshift-ci-robot

/cherrypick enterprise-4.17

EricPonvelle avatar Nov 12 '24 16:11 EricPonvelle

/cherrypick enterprise-4.18

EricPonvelle avatar Nov 12 '24 16:11 EricPonvelle

@EricPonvelle: new pull request created: #84828

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EricPonvelle: new pull request created: #84829

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.