openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

bugfix: vendor titles accuracy

Open sean-freeman opened this issue 1 year ago • 7 comments

Address GH Issue #81621 for infrastructure platform vendor-specific names in documentation titles were inconsistent with vendor. The commit is nonintrusive and does not alter the structure of any topic object; split commit from rejected PR #83244.

Version(s): 4.17, do not cherry pick as this file is likely to have changed between each version

Issue:

  • None (GH or Jira), this is community author contribution

QE review:

  • [ ] QE has approved this change.

Additional information:

  • n/a

The following renames occured for consistency

Installing IBM Cloud Bare Metal (Classic)
>>>
Installing on IBM Cloud (Classic)
Installing on vSphere
>>>
Installing on VMware vSphere

sean-freeman avatar Oct 10 '24 12:10 sean-freeman

@kalexand-rh @bscott-rh @sheriff-rh Mentioning you all, as GH Issue template requests @openshift/team-documentation [which does not work] is mentioned after PR is raised.

sean-freeman avatar Oct 10 '24 12:10 sean-freeman

Hi @sean-freeman. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Oct 10 '24 12:10 openshift-ci[bot]

@kalexand-rh @bscott-rh @sheriff-rh Can you please review this PR? I would prefer to avoid merge conflicts which is more likely the longer this PR is open.

sean-freeman avatar Oct 21 '24 15:10 sean-freeman

/ok-to-test

bscott-rh avatar Oct 24 '24 15:10 bscott-rh

🤖 Thu Oct 24 16:16:42 - Prow CI generated the docs preview:

https://83335--ocpdocs-pr.netlify.app/

ocpdocs-previewbot avatar Oct 24 '24 16:10 ocpdocs-previewbot

@sean-freeman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 24 '24 16:10 openshift-ci[bot]

@bscott-rh ready for merge

sean-freeman avatar Oct 24 '24 20:10 sean-freeman

/cherrypick enterprise-4.17

mburke5678 avatar Oct 28 '24 19:10 mburke5678

/cherrypick enterprise-4.18

mburke5678 avatar Oct 28 '24 19:10 mburke5678

@mburke5678: new pull request created: #84180

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mburke5678: new pull request created: #84181

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.