openshift-docs
openshift-docs copied to clipboard
openshift
[WIP] OSDOCS-12183: adding how to delete manifests
Version(s): 4.18+
Issue: OSDOCS-12183
Link to docs preview: Deleting resource manifests
QE review:
- [x] QE has approved this change.
SME review:
- [x] SME has approved this change.
@aravipra: This pull request references OSDOCS-12183 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Version(s): 4.18+
Issue: OSDOCS-12183
Link to docs preview:
QE review:
- [ ] QE has approved this change.
SME review:
- [ ] SME has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
🤖 Mon Nov 04 07:52:27 - Prow CI generated the docs preview:
https://83246--ocpdocs-pr.netlify.app/microshift/latest/microshift_running_apps/microshift-deleting-resource-manifests.html
@aravipra: This pull request references OSDOCS-12183 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Version(s): 4.18+
Issue: OSDOCS-12183
Link to docs preview: Deleting resource manifests
QE review:
- [ ] QE has approved this change.
SME review:
- [ ] SME has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@aravipra: This pull request references OSDOCS-12183 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Version(s): 4.18+
Issue: OSDOCS-12183
Link to docs preview: Deleting resource manifests
QE review:
- [ ] QE has approved this change.
SME review:
- [x] SME has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
A note should be added that the end user is responsible for cleaning up the manifest files in the delete directory. They are not automatically removed as part of the deleting manifest resources.
I'm not sure how much detail should be added, but should steps be added to cover the Manifest removal scenario in /usr/lib/microshift/manifests.d/delete/* and /usr/lib/microshift/manifests/delete/ ? This directory is read-only for OSTree deployment and requires extra steps be followed to place files in the delete directory. The YAML file(s) need to be packaged into an RPM , and that RPM is added to a blueprint.
For RPM installations the /usr/lib/microshift/manifests.d/delete/* and /usr/lib/microshift/manifests/delete/ allow the directory to be created
A note should be added that the end user is responsible for cleaning up the manifest files in the
deletedirectory. They are not automatically removed as part of the deleting manifest resources.
done
I'm not sure how much detail should be added, but should steps be added to cover the Manifest removal scenario in
/usr/lib/microshift/manifests.d/delete/*and/usr/lib/microshift/manifests/delete/? This directory is read-only for OSTree deployment and requires extra steps be followed to place files in thedeletedirectory. The YAML file(s) need to be packaged into an RPM , and that RPM is added to a blueprint.For RPM installations the
/usr/lib/microshift/manifests.d/delete/*and/usr/lib/microshift/manifests/delete/allow the directory to be created
The manifest removal scenario has general steps mentioned in it. May be a note would be good is my suggestion. @pmtk Please suggest.
@aravipra: This pull request references OSDOCS-12183 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Version(s): 4.18+
Issue: OSDOCS-12183
Link to docs preview: Deleting resource manifests
QE review:
- [ ] QE has approved this change.
SME review:
- [x] SME has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@aravipra: This pull request references OSDOCS-12183 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Version(s): 4.18+
Issue: OSDOCS-12183
Link to docs preview: Deleting resource manifests
QE review:
- [x] QE has approved this change.
SME review:
- [x] SME has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@aravipra I have a few suggestions, which could wait for a follow-up PR, if you prefer, as this is for 4.18 only.
I am confused by a couple of things. Maybe it is my ignorance of MicroShift:
- Are the manifests all Kustomize? You go back and forth between "Kustomize manifest" and "manifests", which is fine. If the manifests are all Kustomize manifests, maybe make sure the first reference is Kustomize and add Kustomize to the assembly title?
- Are we deleting the manifest files themselves, or the "resources defined" in the manifests. I thought it was just the files at first, but now I think it is the resources (also?).
@aravipra: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@mburke5678: new pull request created: #84480
In response to this:
/cherrypick enterprise-4.18
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
PR https://github.com/openshift/openshift-docs/pull/84521 is created to make Assembly heading changes as suggested in https://github.com/openshift/openshift-docs/pull/83246#issuecomment-2447080628 PR https://github.com/openshift/openshift-docs/pull/84633 is created to apply the final changes to delete manifests