openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

[WIP] OSSM-5634: Creating a gateway

Open rh-tokeefe opened this issue 1 year ago • 8 comments

Affects:

service-mesh-docs-main service-mesh-docs-3.0.0tp1

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OSSM-5634

Link to docs preview: https://80920--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/gateways/ossm-about-gateways.html

QE review:

  • [x] QE has approved this change.

Additional information:

rh-tokeefe avatar Aug 26 '24 20:08 rh-tokeefe

@rh-tokeefe: This pull request references OSSM-5634 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 26 '24 20:08 openshift-ci-robot

🤖 Thu Oct 31 17:03:44 - Prow CI generated the docs preview:

https://80920--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/gateways/ossm-about-gateways.html https://80920--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/observability/kiali/ossm-kiali-assembly.html

ocpdocs-previewbot avatar Aug 26 '24 20:08 ocpdocs-previewbot

@rh-tokeefe: This pull request references OSSM-5634 which is a valid jira issue.

In response to this:

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OSSM-5634

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 27 '24 17:08 openshift-ci-robot

@rh-tokeefe: This pull request references OSSM-5634 which is a valid jira issue.

In response to this:

Affects:

service-mesh-docs-main service-mesh-docs-3.0.0tp1

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OSSM-5634

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 27 '24 17:08 openshift-ci-robot

@rh-tokeefe: This pull request references OSSM-5634 which is a valid jira issue.

In response to this:

Affects:

service-mesh-docs-main service-mesh-docs-3.0.0tp1

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OSSM-5634

Link to docs preview: https://80920--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/gateways/ossm-about-gateways.html

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 18 '24 16:10 openshift-ci-robot

Verified after the changes, LGTM...!

pbajjuri20 avatar Oct 24 '24 15:10 pbajjuri20

@rh-tokeefe: This pull request references OSSM-5634 which is a valid jira issue.

In response to this:

Affects:

service-mesh-docs-main service-mesh-docs-3.0.0tp1

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OSSM-5634

Link to docs preview: https://80920--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/gateways/ossm-about-gateways.html

QE review:

  • [x] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 24 '24 16:10 openshift-ci-robot

/retest

rh-tokeefe avatar Oct 28 '24 17:10 rh-tokeefe

/label peer-review-needed

rh-tokeefe avatar Oct 29 '24 17:10 rh-tokeefe

@rh-tokeefe A few suggestions, mostly style issues. Otherwise LGTM. Nice and clean!

mburke5678 avatar Oct 30 '24 18:10 mburke5678

/label merge-review-needed

rh-tokeefe avatar Oct 30 '24 20:10 rh-tokeefe

Rebased to resolve merge conflict.

rh-tokeefe avatar Oct 31 '24 11:10 rh-tokeefe

@mburke5678 Looks like the change is in and the merge conflict has been resolved.

rh-tokeefe avatar Oct 31 '24 13:10 rh-tokeefe

@rh-tokeefe could you squash your commits? Once you do I can merge! 😄

opayne1 avatar Oct 31 '24 15:10 opayne1

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 31 '24 17:10 openshift-ci[bot]

/cherrypick service-mesh-docs-3.0.0tp1

opayne1 avatar Oct 31 '24 18:10 opayne1

@opayne1: new pull request created: #84334

In response to this:

/cherrypick service-mesh-docs-3.0.0tp1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.