openshift-docs
openshift-docs copied to clipboard
OSDOCS-10369:Add info on CPMS to OSD/ROSA docs.
Version(s): 4.16+
Issue: OSDOCS-10369
Link to docs preview:
ROSA Docs: Automatic updates to the control plane configuration
OSD Docs: Automatic updates to the control plane configuration
Peer review:
- [ ] Peer reviewer has approved this change.
SME review:
- [ ] SME has approved this change.
QE review:
- [ ] QE has approved this change.
Additional information:
@AedinC: This pull request references OSDOCS-10369 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Version(s): 4.16+
Issue: OSDOCS-10369
Link to docs preview:
Peer review:
- [ ] Peer reviewer has approved this change.
SME review:
- [ ] SME has approved this change.
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
🤖 Mon Jul 08 15:17:08 - Prow CI generated the docs preview:
https://78165--ocpdocs-pr.netlify.app/openshift-dedicated/latest/architecture/control-plane.html https://78165--ocpdocs-pr.netlify.app/openshift-enterprise/latest/architecture/control-plane.html https://78165--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/control_plane_machine_management/cpmso-managing-machines.html https://78165--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/control_plane_machine_management/cpmso-resiliency.html https://78165--ocpdocs-pr.netlify.app/openshift-rosa/latest/architecture/control-plane.html
@AedinC: This pull request references OSDOCS-10369 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Version(s): 4.16+
Issue: OSDOCS-10369
Link to docs preview:
ROSA Docs: Automatic updates to the control plane configuration
OSD Docs: Automatic updates to the control plane configuration
Peer review:
- [ ] Peer reviewer has approved this change.
SME review:
- [ ] SME has approved this change.
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hi @abyrne55. Can you have a look at this when you get a chance please and let me know if you think there is anything else I should add before I send it for a more technical review? Thanks!
/label peer-review-needed
@AlexVulaj @RaphaelBut Can one of you please review this to see if anything else needs to be added? Many thanks.
This looks great! Nothing from my side to be added.
This looks great! Nothing from my side to be added.
Thanks @RaphaelBut
/remove-label peer-review-needed
/label peer-review-in-progress
@AedinC: This pull request references OSDOCS-10369 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Version(s): 4.16+
Issue: OSDOCS-10369
Link to docs preview:
ROSA Docs: Automatic updates to the control plane configuration
OSD Docs: Automatic updates to the control plane configuration
Peer review:
- [x] Peer reviewer has approved this change.
SME review:
- [ ] SME has approved this change.
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@AedinC: This pull request references OSDOCS-10369 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Version(s): 4.16+
Issue: OSDOCS-10369
Link to docs preview:
ROSA Docs: Automatic updates to the control plane configuration
OSD Docs: Automatic updates to the control plane configuration
Peer review:
- [x] Peer reviewer has approved this change.
SME review:
- [x] SME has approved this change.
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
One note here about the structure of the update module for keeping this maintainable across different distros. Also related to maintenance, can you please be sure to update the
// Module included in the following assemblies:section in each module so that we can keep track of where they are used?For peer review, should also have this location linked (since there are changes to that module): Automatic updates to the control plane configuration
Apologies @dfitzmau- can you also review this module? Will add it to the main body of the PR.
@AedinC: This pull request references OSDOCS-10369 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Version(s): 4.16+
Issue: OSDOCS-10369
Link to docs preview:
ROSA Docs: Automatic updates to the control plane configuration
OSD Docs: Automatic updates to the control plane configuration
OCP Docs: Automatic updates to the control plane configuration
Peer review:
- [x] Peer reviewer has approved this change.
SME review:
- [x] SME has approved this change.
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Thanks, @AedinC . I already reviewed this module from a link provided in the ocpdocs-previewbot comment. openshift-dedicate and openshift-rosa is not present in this module. Thanks! LGTM.
/lgtm
@AedinC: This pull request references OSDOCS-10369 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Version(s): 4.16+
Issue: OSDOCS-10369
Link to docs preview:
ROSA Docs: Automatic updates to the control plane configuration
OSD Docs: Automatic updates to the control plane configuration
OCP Docs: Automatic updates to the control plane configuration
Peer review:
- [x] Peer reviewer has approved this change.
SME review:
- [x] SME has approved this change.
QE review:
- [x] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/label merge-review-needed
New changes are detected. LGTM label has been removed.
@AedinC: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16
@jeana-redhat: new pull request created: #78573
In response to this:
/cherrypick enterprise-4.17
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@jeana-redhat: new pull request created: #78574
In response to this:
/cherrypick enterprise-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.