openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

Simply nmconnection files

Open tyll opened this issue 1 year ago • 11 comments

Remove empty properties that are not needed to make the documentation more focussed. It also removes an unused property (mac-address-blacklist) that is deprecated as part of the conscious language efforts in NetworkManager.

  • For more details about the information requested in this template, see: https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/create_or_edit_content.adoc#submit-PR --->

Version(s): all

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information: This change is valid for all supported OCP releases but not necessary.

/label merge-review-needed

@bengal @ffmancera @cathay4t FYI

tyll avatar Jun 26 '24 09:06 tyll

/label merge-review-needed

tyll avatar Jun 26 '24 09:06 tyll

@tyll: Can not set label merge-review-needed: Must be member in one of these teams: [team-red-hat]

In response to this:

Remove empty properties that are not needed to make the documentation more focussed. It also removes an unused property (mac-address-blacklist) that is deprecated as part of the conscious language efforts in NetworkManager.

  • For more details about the information requested in this template, see: https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/create_or_edit_content.adoc#submit-PR --->

Version(s): all

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information: This change is valid for all supported OCP releases but not necessary.

/label merge-review-needed

@bengal @ffmancera @cathay4t

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jun 26 '24 09:06 openshift-ci[bot]

@tyll: Can not set label merge-review-needed: Must be member in one of these teams: [team-red-hat]

In response to this:

/label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jun 26 '24 09:06 openshift-ci[bot]

Hi @tyll. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jun 26 '24 09:06 openshift-ci[bot]

@openshift/team-documentation @kalexand-rh please review this

tyll avatar Jun 26 '24 09:06 tyll

/ok-to-test

kalexand-rh avatar Jun 26 '24 12:06 kalexand-rh

@jldohmann, will you PTAL?

kalexand-rh avatar Jun 26 '24 12:06 kalexand-rh

🤖 Wed Jun 26 12:47:34 - Prow CI generated the docs preview:

https://78072--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/installing-bare-metal.html https://78072--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/installing-bare-metal-network-customizations.html https://78072--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/installing-restricted-networks-bare-metal.html

ocpdocs-previewbot avatar Jun 26 '24 12:06 ocpdocs-previewbot

@tyll: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 26 '24 12:06 openshift-ci[bot]

previews: iso: https://78072--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/installing-bare-metal.html#installation-user-infra-machines-advanced-customizing-live-iso_network_keyfile_installing-bare-metal pxe: https://78072--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/installing-bare-metal.html#installation-user-infra-machines-advanced-customizing-live-pxe_network_keyfile_installing-bare-metal

jldohmann avatar Jul 03 '24 20:07 jldohmann

thanks for opening this, Till! 😄

jldohmann avatar Jul 03 '24 20:07 jldohmann

LGTM

mike-nguyen avatar Jul 09 '24 16:07 mike-nguyen

/cherrypick enterprise-4.17

jldohmann avatar Jul 09 '24 16:07 jldohmann

/cherrypick enterprise-4.16

jldohmann avatar Jul 09 '24 16:07 jldohmann

/cherrypick enterprise-4.15

jldohmann avatar Jul 09 '24 16:07 jldohmann

/cherrypick enterprise-4.14

jldohmann avatar Jul 09 '24 16:07 jldohmann

/cherrypick enterprise-4.13

jldohmann avatar Jul 09 '24 16:07 jldohmann

/cherrypick enterprise-4.12

jldohmann avatar Jul 09 '24 16:07 jldohmann

@jldohmann: new pull request created: #78676

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jldohmann: new pull request created: #78677

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jldohmann: new pull request created: #78678

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jldohmann: new pull request created: #78679

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jldohmann: new pull request created: #78680

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jldohmann: new pull request created: #78681

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.