openshift-docs
openshift-docs copied to clipboard
OSDOCS - CNV-38323: Reverting a bug fix description in the RNs
Version(s): 4.14 (and possibly 4.15 as well)
Issue: https://issues.redhat.com/browse/CNV-38323
Link to docs preview: https://78023--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-14-release-notes.html
QE review:
- [ ] QE has approved this change.
@jherrman: This pull request references CNV-38323 which is a valid jira issue.
In response to this:
Version(s): 4.14 (and possibly 4.15 as well)
Issue: https://issues.redhat.com/browse/CNV-38323
Link to docs preview: TBA
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
🤖 Wed Sep 04 09:43:15 - Prow CI generated the docs preview:
https://78023--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-14-release-notes.html
@jherrman: This pull request references CNV-38323 which is a valid jira issue.
In response to this:
Version(s): 4.14 (and possibly 4.15 as well)
Issue: https://issues.redhat.com/browse/CNV-38323
Link to docs preview: https://78023--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-14-release-notes.html
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Note - As confirmed by Nijin in https://issues.redhat.com/browse/CNV-38323 , this should be applied to enterprise-4.14 as well (most likely via cherry-pick after the initial merge)
/label peer-review-needed
/remove-label peer-review-needed
/label peer-review-in-progress
Hi @jherrman . The merger would need to know for sure if 4.15 is impacted. Can you confirm? Bug was fixed in 4.16?
Hi @jherrman . The merger would need to know for sure if 4.15 is impacted. Can you confirm? Bug was fixed in 4.16?
@dfitzmau SME confirmed in https://issues.redhat.com/browse/CNV-38323 that the issue impacts 4.15 and 4.16 as well (and possibly will for 4.17, too).
Thanks, @jherrman . LGTM. WOuld you be OK to update the following description item to state "4.14+"?
@jherrman: This pull request references CNV-38323 which is a valid jira issue.
In response to this:
Version(s): 4.14+
Issue: https://issues.redhat.com/browse/CNV-38323
Link to docs preview: https://78023--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-14-release-notes.html
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Thanks, @jherrman . LGTM. WOuld you be OK to update the following description item to state "4.14+"?
Done, thank you for the heads-up :-)
/lgtm
/label merge-review-needed
@jherrman, if this is intended for 4.14+, I think this should be a PR against the main branch and not the enterprise-4.14 branch? Thanks!
@jherrman: This pull request references CNV-38323 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.
In response to this:
Version(s): 4.14+
Issue: https://issues.redhat.com/browse/CNV-38323
Link to docs preview: https://78023--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-14-release-notes.html
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@jherrman: This pull request references CNV-38323 which is a valid jira issue.
In response to this:
Version(s): 4.14+
Issue: https://issues.redhat.com/browse/CNV-38323
Link to docs preview: https://78023--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-14-release-notes.html
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@jherrman, if this is intended for 4.14+, I think this should be a PR against the
mainbranch and not theenterprise-4.14branch? Thanks!
@jab-rh , my apologies, must have missed that in the OpenShift docs manual. Still, is it necessary? Changing the base branch to "main" complicates the PR quite a lot (due to the many added commits), and it's just a single very simple change, which should be easy to cherry-pick to other branches.
@kalexand-rh, can this be cherry-picked around from enterprise-4.14 or should this be re-done against main? Thanks!
It's not one of the repo best practices to cherry-pick to main, but if you can find a merge reviewer who is willing to make sure that no other changes creep into other branches, you can.
Thank you for the info Kathryn!
However, one thing I did not realize earlier is that as an update to Release Notes, this cannot really be merged into Main. Also, as a bug fix description becoming a known issue description, it cannot be easily cherry-picked to the newer branches without conflict (since the newer branches don't contain the original bug fix).
So, this PR should still cover 4.14 (I changed the original description to reflect that) and I created a new one for 4.15 - 4.17: https://github.com/openshift/openshift-docs/pull/78023 - which should theoretically be cherry-pickable without much trouble
Hopefully this does the trick, apologies for the shenanigans...
@jherrman, can you squad the commits for this PR? Thank you!
New changes are detected. LGTM label has been removed.
@jherrman: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/label merge-review-needed