openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

PR for SRVLOGIC-189: Added the installtion and uninstallation assemblies for Openshift Serverless Logic docs

Open kaldesai opened this issue 1 year ago • 10 comments

Affected versions for cherry-picking: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-189

Doc previews

Note for the merge reviewer: The developers will provide a link to download the binary files. Once we receive the link, I will update it in the procedure step 1. This pull request is okay to merge, and the rest of the content has been peer-reviewed. We are just holding it as the developers will provide the link.

kaldesai avatar May 25 '24 19:05 kaldesai

@kaldesai: This pull request references SRVLOGIC-189 which is a valid jira issue.

In response to this:

Affected versions for cherry-picking: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-189

Doc previews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 25 '24 19:05 openshift-ci-robot

🤖 Fri Jul 12 12:18:54 - Prow CI generated the docs preview: https://76488--ocpdocs-pr.netlify.app Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

ocpdocs-previewbot avatar May 25 '24 19:05 ocpdocs-previewbot

@kaldesai: This pull request references SRVLOGIC-189 which is a valid jira issue.

In response to this:

Affected versions for cherry-picking: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-189

Doc previews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 25 '24 19:05 openshift-ci-robot

@kaldesai: This pull request references SRVLOGIC-189 which is a valid jira issue.

In response to this:

Affected versions for cherry-picking: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-189

Doc previews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 01 '24 10:07 openshift-ci-robot

@kaldesai: This pull request references SRVLOGIC-189 which is a valid jira issue.

In response to this:

Affected versions for cherry-picking: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-189

Doc previews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 01 '24 10:07 openshift-ci-robot

@ricardozanini Thank you for approving the PR. @wmedvede, I have incorporated your suggestions. @domhanak

It would be nice if you take a look at the new Installing the OpenShift Serverless Logic Operator using the Knative workflow plugin from the CLI section.

kaldesai avatar Jul 01 '24 10:07 kaldesai

/label peer-review-needed

kaldesai avatar Jul 01 '24 10:07 kaldesai

@kaldesai I have a few suggestions. Otherwise LGTM

mburke5678 avatar Jul 02 '24 13:07 mburke5678

@kaldesai: This pull request references SRVLOGIC-189 which is a valid jira issue.

In response to this:

Affected versions for cherry-picking: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-189

Doc previews

Note for the merge reviewer: The developers will provide a link to download the binary files. Once we receive the link, I will update it in the procedure step 1. This pull request is okay to merge, and the rest of the content has been peer-reviewed. We are just holding it as the developers will provide the link.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 03 '24 13:07 openshift-ci-robot

/label do-not-merge

kaldesai avatar Jul 05 '24 14:07 kaldesai

@kaldesai: The label(s) /label do-not-merge cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label do-not-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jul 05 '24 14:07 openshift-ci[bot]

Imho this should be Install Openshift Serverless Logic

image

domhanak avatar Jul 08 '24 09:07 domhanak

@kaldesai Just to be more clear, i think we need to have this structure:

  • Install Openshift Serverless Logic -- Install Openshift Serverless Logic -- Installing the OpenShift Serverless Logic Operator from the web console -- Installing the OpenShift Serverless Logic Knative Workflow plugin

domhanak avatar Jul 08 '24 09:07 domhanak

Allthought the latets update also looks good ( where KN guide is separate section in the left menu ) yet I was under impression we want to have v=everything under one Install Openshift Serverless Logic chapter on the left

domhanak avatar Jul 08 '24 09:07 domhanak

  1. User selects: image
  2. User sees:

Installing the OpenShift Serverless Logic

Installing the OpenShift Serverless Logic enables you to install and use Serverless Workflow on a OpenShift Container Platform cluster. The OpenShift Serverless Logic Operator manages Kubernetes custom resource definitions (CRDs) to configure and deploy the workflows.

Installing the OpenShift Serverless Logic Operator from the web console

insert text here

Installing the OpenShift Serverless Logic Knative Workflow plugin

insert text here

domhanak avatar Jul 08 '24 09:07 domhanak

@kaldesai @wmedvede I might be a bit of out sync, so just let me know when updated accordingly :)

domhanak avatar Jul 08 '24 09:07 domhanak

Imho this should be Install Openshift Serverless Logic

image

Hi @domhanak @kaldesai , let's go with the splitted approach I suggested;

Screenshot from 2024-07-08 10-14-29

wmedvede avatar Jul 08 '24 09:07 wmedvede

@kaldesai: This pull request references SRVLOGIC-189 which is a valid jira issue.

In response to this:

Affected versions for cherry-picking: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-189

Doc previews

Note for the merge reviewer: The developers will provide a link to download the binary files. Once we receive the link, I will update it in the procedure step 1. This pull request is okay to merge, and the rest of the content has been peer-reviewed. We are just holding it as the developers will provide the link.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 08 '24 11:07 openshift-ci-robot

Imho this should be Install Openshift Serverless Logic

image

As per the discussion, we are going to keep the content as it is. We can get back to the structure post GA along with CS and DPM.

kaldesai avatar Jul 08 '24 11:07 kaldesai

@domhanak As per the discussion, we are going to keep the content as it is. We can get back to the structure post GA along with CS and DPM. Thank you for reviewing!

kaldesai avatar Jul 08 '24 11:07 kaldesai

/label merge-review-needed

kaldesai avatar Jul 08 '24 14:07 kaldesai

@kaldesai: This pull request references SRVLOGIC-189 which is a valid jira issue.

In response to this:

Note for the merge reviewer: The developers will provide a link to download the binary files. Once we receive the link, I will update it in the procedure step 1. This pull request is okay to merge, and the rest of the content has been peer-reviewed. We are just holding it as the developers will provide the link.

Affected versions for cherry-picking: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-189

Doc previews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 08 '24 14:07 openshift-ci-robot

@kaldesai: This pull request references SRVLOGIC-189 which is a valid jira issue.

In response to this:

Note for the merge reviewer: The developers will provide a link to download the binary files. Once we receive the link, I will update it in the procedure step 1. This pull request is okay to merge, and the rest of the content has been peer-reviewed. We are just holding it as the developers will provide the link. please hold off on merging the PR as we are waiting for the product team to give us the green signal. Once we receive their approval, the PR will be ready to merge with everything in place. Till then you can go ahead and verify the content and add LGTM if everything is fine.

Affected versions for cherry-picking: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-189

Doc previews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 08 '24 15:07 openshift-ci-robot

@kaldesai: This pull request references SRVLOGIC-189 which is a valid jira issue.

In response to this:

Note for the merge reviewer: The developers will provide a link to download the binary files. Once we receive the link, I will update it in the procedure step 1. This pull request is okay to merge, and the rest of the content has been peer-reviewed. We are just holding it as the developers will provide the link. please hold off on merging the PR as we are waiting for the product team to give us the green signal. Once we receive their approval, the PR will be ready to merge with everything in place. Till then you can go ahead and verify the content and add LGTM if everything is fine.

Affected versions for cherry-picking: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-189

Doc previews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 10 '24 13:07 openshift-ci-robot

@kaldesai: This pull request references SRVLOGIC-189 which is a valid jira issue.

In response to this:

Note for the merge reviewer: The developers will provide a link to download the binary files. Once we receive the link, I will update it in the procedure step 1. This pull request is okay to merge, and the rest of the content has been peer-reviewed. We are just holding it as the developers will provide the link. please hold off on merging the PR as we are waiting for the product team to give us the green signal. Once we receive their approval, the PR will be ready to merge with everything in place. Till then you can go ahead and verify the content and add LGTM if everything is fine.

Affected versions for cherry-picking: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-189

Doc previews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 10 '24 13:07 openshift-ci-robot

@jeana-redhat I have incorporated all of your suggestions. Thank you!

kaldesai avatar Jul 11 '24 04:07 kaldesai

@kaldesai: This pull request references SRVLOGIC-189 which is a valid jira issue.

In response to this:

Affected versions for cherry-picking: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-189

Doc previews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 12 '24 12:07 openshift-ci-robot

@kaldesai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 12 '24 12:07 openshift-ci[bot]

/cherrypick serverless-docs-1.33

jeana-redhat avatar Jul 15 '24 13:07 jeana-redhat

remove /hold

kaldesai avatar Jul 15 '24 13:07 kaldesai