openshift-docs
openshift-docs copied to clipboard
openshift
PR for SRVLOGIC-209: Add the "Openshift Serverless Logic overview" assembly.
Affected versions: serverless-docs-1.33
Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-209
Doc preview: Openshift Serverless Logic overview
@kaldesai: This pull request references SRVLOGIC-209 which is a valid jira issue.
In response to this:
Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-209
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
🤖 Mon Jul 15 15:44:38 - Prow CI generated the docs preview:
https://75129--ocpdocs-pr.netlify.app/openshift-serverless/latest/about/serverless-logic-overview.html
@kaldesai: This pull request references SRVLOGIC-209 which is a valid jira issue.
In response to this:
Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-209
Doc preview: Serverless Logic overview
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Commented here as I did not know about this PR - https://github.com/openshift/openshift-docs/pull/70393
Also, comparing to the docs we have upstream, it feels like reduction of information that is available to the user. For example, callbacks overview gives no overview about callbacks, I doubt user will be able to understand what a callback is and what to use it for. Wdyt?
@wmedvede @domhanak @fjtirado @ricardozanini I have incorporated your suggestions in the drafts.
@kaldesai: This pull request references SRVLOGIC-209 which is a valid jira issue.
In response to this:
Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-209
Doc preview: Openshift Serverless Logic overview
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@kaldesai: This pull request references SRVLOGIC-209 which is a valid jira issue.
In response to this:
Affected versions:
serverless-docs-1.33Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-209
Doc preview: Openshift Serverless Logic overview
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Also, I did mark this once in the doc, but all of the headings need anchor IDs - there are a lot (especially 2nd level) in the modules that are missing these anchor IDs. I think this is needed for the publishing process and URL navigation.
Also, I did mark this once in the doc, but all of the headings need anchor IDs - there are a lot (especially 2nd level) in the modules that are missing these anchor IDs. I think this is needed for the publishing process and URL navigation.
I have included the anchor IDs and the context variables. Thank you so much for capturing this.
@wmedvede @domhanak @fjtirado @ricardozanini I have incorporated your suggestions in the drafts.
/lgtm
I understand that more approvals are needed prior to merge, so I will stop here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@kaldesai: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@jeana-redhat: new pull request created: #78893
In response to this:
/cherrypick serverless-docs-1.33
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
