openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OCPBUGS#30993: Doc improvements related to RHACM procs

Open sr1kar99 opened this issue 1 year ago • 8 comments

Version(s): 4.15+

Issue: OCPBUGS-30993

Link to docs preview: Preview

QE review:

  • [x] QE has approved this change.

Additional information:

sr1kar99 avatar Mar 18 '24 10:03 sr1kar99

🤖 Sun Apr 14 03:59:24 - Prow CI generated the docs preview:

https://73279--ocpdocs-pr.netlify.app/ https://73279--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage/persistent_storage_local/persistent-storage-using-lvms.html

ocpdocs-previewbot avatar Mar 18 '24 10:03 ocpdocs-previewbot

@radeore Can you please review this PR? Thanks.

sr1kar99 avatar Mar 19 '24 05:03 sr1kar99

@sr1kar99 Verified the procedures on ACM cluster, suggested few changes, PTAL. Thanks!

radeore avatar Mar 19 '24 21:03 radeore

/lgtm

radeore avatar Mar 22 '24 15:03 radeore

/label peer-review-needed

sr1kar99 avatar Mar 22 '24 16:03 sr1kar99

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Mar 24 '24 08:03 openshift-ci[bot]

@jakobmoellerdev Can you please review this PR? Thanks.

sr1kar99 avatar Mar 26 '24 04:03 sr1kar99

/retest

sr1kar99 avatar Mar 26 '24 15:03 sr1kar99

Hi @radeore Jakob has left a few queries. Could you PTAL? Thanks.

sr1kar99 avatar Mar 27 '24 14:03 sr1kar99

Hi @jakobmoellerdev Could you please confirm if the updates are fine? Thanks.

sr1kar99 avatar Apr 09 '24 13:04 sr1kar99

/label merge-review-needed

sr1kar99 avatar Apr 10 '24 17:04 sr1kar99

Overall, looks good! I would like to hold merge, however, for a couple of user-replaceables using dashes. I'll keep the merge-review-in-progress label on it tho and I'll keep an eye out for an update. Feel free to ping on Slack as well. Thank you!

Edit: Also added a question about using ocp in a replaceable without a conditional.

Hi @adellape Thank you for the detailed review. Updated the content based on the suggestions. Could you PTAL? Thanks.

sr1kar99 avatar Apr 11 '24 09:04 sr1kar99

@sr1kar99: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 14 '24 04:04 openshift-ci[bot]

/cherrypick enterprise-4.16

adellape avatar Apr 16 '24 14:04 adellape

/cherrypick enterprise-4.15

adellape avatar Apr 16 '24 14:04 adellape

@adellape: new pull request created: #74709

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adellape: new pull request created: #74710

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.