openshift-docs
openshift-docs copied to clipboard
OCPBUGS#30993: Doc improvements related to RHACM procs
Version(s): 4.15+
Issue: OCPBUGS-30993
Link to docs preview: Preview
QE review:
- [x] QE has approved this change.
Additional information:
🤖 Sun Apr 14 03:59:24 - Prow CI generated the docs preview:
https://73279--ocpdocs-pr.netlify.app/ https://73279--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage/persistent_storage_local/persistent-storage-using-lvms.html
@radeore Can you please review this PR? Thanks.
@sr1kar99 Verified the procedures on ACM cluster, suggested few changes, PTAL. Thanks!
/lgtm
/label peer-review-needed
New changes are detected. LGTM label has been removed.
@jakobmoellerdev Can you please review this PR? Thanks.
/retest
Hi @radeore Jakob has left a few queries. Could you PTAL? Thanks.
Hi @jakobmoellerdev Could you please confirm if the updates are fine? Thanks.
/label merge-review-needed
Overall, looks good! I would like to hold merge, however, for a couple of user-replaceables using dashes. I'll keep the
merge-review-in-progresslabel on it tho and I'll keep an eye out for an update. Feel free to ping on Slack as well. Thank you!Edit: Also added a question about using
ocpin a replaceable without a conditional.
Hi @adellape Thank you for the detailed review. Updated the content based on the suggestions. Could you PTAL? Thanks.
@sr1kar99: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
/cherrypick enterprise-4.16
/cherrypick enterprise-4.15
@adellape: new pull request created: #74709
In response to this:
/cherrypick enterprise-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@adellape: new pull request created: #74710
In response to this:
/cherrypick enterprise-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.