managed-upgrade-operator icon indicating copy to clipboard operation
managed-upgrade-operator copied to clipboard

Use 'eus' channel

Open jewzaam opened this issue 1 year ago • 4 comments

What type of PR is this?

feature

What this PR does / why we need it?

uses "eus" channel for 4.12+ even versions

Which Jira/Github issue(s) this PR fixes?

https://issues.redhat.com/browse/SDCICD-1365

Special notes for your reviewer:

do not promote to prod until this bakes in int/stage for a while

Pre-checks (if applicable):

  • [ ] Tested latest changes against a cluster
  • [ ] Included documentation changes with PR

jewzaam avatar Aug 20 '24 17:08 jewzaam

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jewzaam Once this PR has been reviewed and has the lgtm label, please assign bmeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 20 '24 17:08 openshift-ci[bot]

/hold

jewzaam avatar Aug 20 '24 17:08 jewzaam

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.32%. Comparing base (ccd9e44) to head (5cf31ae).

Files Patch % Lines
pkg/ocmprovider/ocmprovider.go 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage   54.34%   54.32%   -0.02%     
==========================================
  Files         122      122              
  Lines        5903     5905       +2     
==========================================
  Hits         3208     3208              
- Misses       2494     2495       +1     
- Partials      201      202       +1     
Files Coverage Δ
pkg/ocmprovider/ocmprovider.go 63.80% <0.00%> (-1.24%) :arrow_down:

codecov-commenter avatar Aug 20 '24 17:08 codecov-commenter

@jewzaam: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 04 '24 20:09 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Dec 04 '24 09:12 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Jan 04 '25 00:01 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Feb 03 '25 08:02 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Feb 03 '25 08:02 openshift-ci[bot]