managed-upgrade-operator
managed-upgrade-operator copied to clipboard
openshift
OSD-22085: Send ServiceLog for alert and CO failure
What type of PR is this?
feature
What this PR does / why we need it?
Which Jira/Github issue(s) this PR fixes?
Special notes for your reviewer:
Pre-checks (if applicable):
- Tested latest changes against a cluster
Received this SL when critical alert UpgradeConfigSyncFailureOver4HrSRE was firing.
@shitaljante: This pull request references OSD-22085 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
What type of PR is this?
feature
What this PR does / why we need it?
Which Jira/Github issue(s) this PR fixes?
Special notes for your reviewer:
Pre-checks (if applicable):
- Tested latest changes against a cluster
Received this SL when critical alert UpgradeConfigSyncFailureOver4HrSRE was firing.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@shitaljante: This pull request references OSD-22085 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
What type of PR is this?
feature
What this PR does / why we need it?
Which Jira/Github issue(s) this PR fixes?
Special notes for your reviewer:
Pre-checks (if applicable):
- Tested latest changes against a cluster
Received this SL when critical alert UpgradeConfigSyncFailureOver4HrSRE was firing.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Codecov Report
Attention: Patch coverage is 42.85714% with 8 lines in your changes are missing coverage. Please review.
Project coverage is 55.88%. Comparing base (
5d6e387) to head (d0d86b0). Report is 4 commits behind head on master.
:exclamation: Current head d0d86b0 differs from pull request most recent head 97afca5
Please upload reports for the commit 97afca5 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #424 +/- ##
==========================================
- Coverage 55.90% 55.88% -0.02%
==========================================
Files 109 109
Lines 4912 4924 +12
==========================================
+ Hits 2746 2752 +6
- Misses 1960 1964 +4
- Partials 206 208 +2
| Files | Coverage Δ | |
|---|---|---|
| pkg/eventmanager/eventmanager.go | 54.36% <100.00%> (+0.90%) |
:arrow_up: |
| pkg/notifier/notifier.go | 0.00% <ø> (ø) |
|
| pkg/notifier/ocmnotifier.go | 38.05% <0.00%> (-0.69%) |
:arrow_down: |
| pkg/upgraders/healthcheckstep.go | 87.50% <50.00%> (-12.50%) |
:arrow_down: |
@shitaljante: This pull request references OSD-22085 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
What type of PR is this?
feature
What this PR does / why we need it?
Which Jira/Github issue(s) this PR fixes?
Special notes for your reviewer:
Pre-checks (if applicable):
- Tested latest changes against a cluster
Received this SL when critical alert UpgradeConfigSyncFailureOver4HrSRE was firing.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@shitaljante: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: a7vicky, shitaljante
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [a7vicky]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment