managed-cluster-config icon indicating copy to clipboard operation
managed-cluster-config copied to clipboard

Revert OCPBUGS-25341 workaround: remove sre-replace-packageserver-csv…

Open Amarthya-v opened this issue 6 months ago • 4 comments

What this PR does

This PR removes the sre-replace-packageserver-csv job and its related resources, which were added in #2140 as a workaround for OCPBUGS-25341.

The original issue has since been resolved and backported. Per recent discussion in the OpenShift Release Oversight channel and confirmation from @jb, this job was intended as a one-shot fix and should have been removed long ago.

Keeping it in place is now causing CI failures for OpenShift 4.20 nightlies, tracked in OCPBUGS-56667, due to new restrictive NetworkPolicies in the olm namespace.

What’s removed

  • SelectorSyncSet named ocpbugs-25341
  • Related manifests:
    • ServiceAccount
    • Role and RoleBinding
    • Job to delete the packageserver CSV
  • All references from hack/00-osd-managed-cluster-config-{stage, integration, production}.yaml.tmpl

Why this is safe

  • The underlying bug was resolved and backported.
  • This was never intended to be a long-term job.
  • Removing it unblocks nightly CI failures without any functional regression risk.

Amarthya-v avatar May 27 '25 15:05 Amarthya-v

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar May 27 '25 15:05 openshift-ci[bot]

/lgtm

christophermancini avatar May 27 '25 15:05 christophermancini

You have conflicts, and don't need to manually patch the hack/ files.

I would reset those changes, rebase, then run make which will do the template generation for you.

joshbranham avatar May 27 '25 17:05 joshbranham

/lgtm

christophermancini avatar May 27 '25 18:05 christophermancini

/approve

dustman9000 avatar May 27 '25 19:05 dustman9000

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amarthya-v, christophermancini, dustman9000, joshbranham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 27 '25 19:05 openshift-ci[bot]

@Amarthya-v: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 27 '25 19:05 openshift-ci[bot]