managed-cluster-config
managed-cluster-config copied to clipboard
added 4.18 admin gate due to kube 1.32 api removals
What type of PR is this?
(bug/feature/cleanup/documentation) feature
What this PR does / why we need it?
The following annotation is needed to upgrade clusters from 4.18 to 4.19.
Which Jira/Github issue(s) this PR fixes?
Fixes #
Special notes for your reviewer:
Pre-checks (if applicable):
-
[ ] Tested latest changes against a cluster
-
[ ] Included documentation changes with PR
-
[ ] If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:
matchExpressions: - key: api.openshift.com/fedramp operator: NotIn values: ["true"]
Can one of the admins verify this patch?
Hi @rcampos2029. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@rcampos2029 Have these been created in the OCM api? Also have you tested an install to ensure it works?
These have not yet been created by the api. I have tested that 4.19 upgrades progress after this admin gate have been added.
/lgtm /approve
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dustman9000, rafael-azevedo, rcampos2029, typeid
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [dustman9000,rafael-azevedo,typeid]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment