managed-cluster-config icon indicating copy to clipboard operation
managed-cluster-config copied to clipboard

added 4.18 admin gate due to kube 1.32 api removals

Open rcampos2029 opened this issue 6 months ago • 3 comments
trafficstars

What type of PR is this?

(bug/feature/cleanup/documentation) feature

What this PR does / why we need it?

The following annotation is needed to upgrade clusters from 4.18 to 4.19.

Which Jira/Github issue(s) this PR fixes?

OCM-15803

Fixes #

Special notes for your reviewer:

Pre-checks (if applicable):

  • [ ] Tested latest changes against a cluster

  • [ ] Included documentation changes with PR

  • [ ] If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

    matchExpressions:
    - key: api.openshift.com/fedramp
      operator: NotIn
      values: ["true"]
    

rcampos2029 avatar May 21 '25 15:05 rcampos2029

Can one of the admins verify this patch?

app-sre-bot avatar May 21 '25 15:05 app-sre-bot

Hi @rcampos2029. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar May 21 '25 15:05 openshift-ci[bot]

@rcampos2029 Have these been created in the OCM api? Also have you tested an install to ensure it works?

rafael-azevedo avatar May 27 '25 18:05 rafael-azevedo

These have not yet been created by the api. I have tested that 4.19 upgrades progress after this admin gate have been added.

rcampos2029 avatar May 27 '25 18:05 rcampos2029

/lgtm /approve

typeid avatar May 28 '25 13:05 typeid

/lgtm /approve

dustman9000 avatar May 28 '25 15:05 dustman9000

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, rafael-azevedo, rcampos2029, typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [dustman9000,rafael-azevedo,typeid]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 28 '25 15:05 openshift-ci[bot]