managed-cluster-config icon indicating copy to clipboard operation
managed-cluster-config copied to clipboard

Add cronjob to olm-dance openshift-ocm-agent-operator

Open ravitri opened this issue 1 year ago • 3 comments
trafficstars

What type of PR is this?

(bug)

What this PR does / why we need it?

This PR is continuation to PR https://github.com/openshift/managed-cluster-config/pull/2237 with some changes (thanks @xiaoyu74 !!)

Which Jira/Github issue(s) this PR fixes?

Fixes # OSD-25349

Special notes for your reviewer:

Pre-checks (if applicable):

  • [ ] Tested latest changes against a cluster

  • [ ] Included documentation changes with PR

  • [ ] If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

    matchExpressions:
    - key: api.openshift.com/fedramp
      operator: NotIn
      values: ["true"]
    

ravitri avatar Oct 09 '24 07:10 ravitri

/hold

ravitri avatar Oct 09 '24 09:10 ravitri

/unhold

ravitri avatar Oct 15 '24 10:10 ravitri

/lgtm

devppratik avatar Oct 16 '24 03:10 devppratik

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devppratik, ravitri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 16 '24 03:10 openshift-ci[bot]

@ravitri: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 16 '24 04:10 openshift-ci[bot]