gcp-project-operator icon indicating copy to clipboard operation
gcp-project-operator copied to clipboard

mockgen deprecated: use uber-go/mock instead

Open sebrandon1 opened this issue 1 month ago • 3 comments

https://github.com/golang/mock is marked as archived as of June 27, 2023. They recommend using go.uber.org/mock.

This PR attempts to change the dependency to one that is maintained.

Tracking issue: https://github.com/redhat-best-practices-for-k8s/telco-bot/issues/45

sebrandon1 avatar Nov 13 '25 21:11 sebrandon1

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1 Once this PR has been reviewed and has the lgtm label, please assign makdaam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 13 '25 21:11 openshift-ci[bot]

Codecov Report

:x: Patch coverage is 32.25806% with 42 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.34%. Comparing base (db73dbf) to head (c11bebf).

Files with missing lines Patch % Lines
pkg/util/mocks/cr-client.go 34.04% 27 Missing and 4 partials :warning:
pkg/util/mocks/status-writer.go 26.66% 10 Missing and 1 partial :warning:
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #271   +/-   ##
=======================================
  Coverage   58.34%   58.34%           
=======================================
  Files          26       26           
  Lines        1942     1942           
=======================================
  Hits         1133     1133           
  Misses        731      731           
  Partials       78       78           
Files with missing lines Coverage Δ
pkg/util/mocks/condition/conditions.go 100.00% <ø> (ø)
pkg/util/mocks/gcpclient/client.go 82.75% <ø> (ø)
.../util/mocks/projectclaim/customeresourceadapter.go 78.04% <ø> (ø)
pkg/util/mocks/status-writer.go 38.09% <26.66%> (ø)
pkg/util/mocks/cr-client.go 38.57% <34.04%> (ø)
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Nov 13 '25 21:11 codecov-commenter

@sebrandon1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate c11bebf6a1d22060be2714140e2b91d1e27ee56c link true /test validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 13 '25 21:11 openshift-ci[bot]