console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-43853: Remove promql-expression-input and table-pagination

Open logonoff opened this issue 1 year ago • 4 comments

Fixes:

https://issues.redhat.com//browse/OCPBUGS-43853

Analysis / Root cause:

In CONSOLE-4187, the metrics page was removed from the console, but some related packages (i.e., the codemirror ones) remained, even though they are now unnecessary

Solution Description:

Remove those files

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

Nothing should have changed testing-wise. Everything should work the same as previously

Browser conformance:

  • [] Chrome
  • [ ] Firefox
  • [ ] Safari

logonoff avatar Oct 25 '24 21:10 logonoff

@logonoff: This pull request references Jira Issue OCPBUGS-43853, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:

https://issues.redhat.com//browse/OCPBUGS-43853

Analysis / Root cause:

In CONSOLE-4187, the metrics page was removed from the console, but some related packages (i.e., the codemirror ones) remained, even though they are now unnecessary

Solution Description:

Remove those files

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

Nothing should have changed testing-wise. Everything should work the same as previously

Browser conformance:

  • [] Chrome
  • [ ] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 25 '24 21:10 openshift-ci-robot

/cc @zhuje /cc @TheRealJon

Are these okay to remove?

logonoff avatar Oct 25 '24 21:10 logonoff

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 26 '24 06:10 openshift-ci[bot]

@logonoff: This pull request references Jira Issue OCPBUGS-43853, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

Fixes:

https://issues.redhat.com//browse/OCPBUGS-43853

Analysis / Root cause:

In CONSOLE-4187, the metrics page was removed from the console, but some related packages (i.e., the codemirror ones) remained, even though they are now unnecessary

Meanwhile in https://github.com/openshift/console/commit/092e20044109d764a65fb0d757405faacd33fc7b, plotly.js was removed, which removes the need for glslify-loader.

Solution Description:

Remove those files

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

Nothing should have changed testing-wise. Everything should work the same as previously

Browser conformance:

  • [] Chrome
  • [ ] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 28 '24 12:10 openshift-ci-robot

/lgtm

TheRealJon avatar Oct 29 '24 20:10 TheRealJon

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 29 '24 20:10 openshift-ci[bot]

@logonoff: Jira Issue OCPBUGS-43853: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43853 has been moved to the MODIFIED state.

In response to this:

Fixes:

https://issues.redhat.com//browse/OCPBUGS-43853

Analysis / Root cause:

In CONSOLE-4187, the metrics page was removed from the console, but some related packages (i.e., the codemirror ones) remained, even though they are now unnecessary

Meanwhile in https://github.com/openshift/console/commit/092e20044109d764a65fb0d757405faacd33fc7b, plotly.js was removed, which removes the need for glslify-loader.

Solution Description:

Remove those files

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

Nothing should have changed testing-wise. Everything should work the same as previously

Browser conformance:

  • [] Chrome
  • [ ] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 30 '24 19:10 openshift-ci-robot

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202410302041.p0.g5e8c422.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Oct 30 '24 22:10 openshift-bot