console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-43718: Edit Deployment and Edit DeploymentConfig takes user to project workloads page

Open Mylanos opened this issue 1 year ago • 4 comments
trafficstars

After making a change in existing deployment or deployment config we should navigate to details page.

Previously we navigated into workloads page in certain namespace via redirect URL. After these changes we follow the navigation suite that was in place for newly created deployments.

After:

https://github.com/user-attachments/assets/f0c222e5-add6-4f9d-99f5-9d82c2553cea

https://github.com/user-attachments/assets/0ccd17c7-7037-455f-8f3f-c3949c2891ed

Mylanos avatar Oct 24 '24 13:10 Mylanos

@Mylanos: This pull request references Jira Issue OCPBUGS-43718, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

After making a change in existing deployment or deployment config we should navigate to details page.

Previously we navigated into workloads page in certain namespace via redirect URL. After these changes we follow the navigation suite that was in place for newly created deployments.

After:

https://github.com/user-attachments/assets/f0c222e5-add6-4f9d-99f5-9d82c2553cea

https://github.com/user-attachments/assets/0ccd17c7-7037-455f-8f3f-c3949c2891ed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 24 '24 13:10 openshift-ci-robot

/retest

Mylanos avatar Oct 24 '24 22:10 Mylanos

/retest

Mylanos avatar Oct 29 '24 13:10 Mylanos

/retest

Mylanos avatar Oct 30 '24 09:10 Mylanos

@Mylanos: This pull request references Jira Issue OCPBUGS-43718, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to this:

After making a change in existing deployment or deployment config we should navigate to details page.

Previously we navigated into workloads page in certain namespace via redirect URL. After these changes we follow the navigation suite that was in place for newly created deployments.

After:

https://github.com/user-attachments/assets/f0c222e5-add6-4f9d-99f5-9d82c2553cea

https://github.com/user-attachments/assets/0ccd17c7-7037-455f-8f3f-c3949c2891ed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 30 '24 15:10 openshift-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, Mylanos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 31 '24 10:10 openshift-ci[bot]

@Mylanos: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 31 '24 15:10 openshift-ci[bot]

@Mylanos: Jira Issue OCPBUGS-43718: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43718 has been moved to the MODIFIED state.

In response to this:

After making a change in existing deployment or deployment config we should navigate to details page.

Previously we navigated into workloads page in certain namespace via redirect URL. After these changes we follow the navigation suite that was in place for newly created deployments.

After:

https://github.com/user-attachments/assets/f0c222e5-add6-4f9d-99f5-9d82c2553cea

https://github.com/user-attachments/assets/0ccd17c7-7037-455f-8f3f-c3949c2891ed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 31 '24 15:10 openshift-ci-robot

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202410311939.p0.gee79097.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Oct 31 '24 21:10 openshift-bot