console
console copied to clipboard
openshift
CONSOLE-4227: refactor deprecated multiselectdropdown
Refactors multiselectdropdown to use Patternfly's MultiTypeaheadSelect template, which uses our new Select components, and brings the template package in. The main benefit of using this package is a lot of the filtering + keyboard logic and setup is handled internally by the template, saving about 250 lines of code. If there is any problem with adding the dependency, lmk and I can refactor without using the template.
@kmcfaul: This pull request references CONSOLE-4227 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hi @kmcfaul. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@kmcfaul: This pull request references CONSOLE-4227 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Refactors multiselectdropdown to use Patternfly's
MultiTypeaheadSelecttemplate, which uses our newSelectcomponents, and brings the template package in. The main benefit of using this package is a lot of the filtering + keyboard logic and setup is handled internally by the template, saving about 250 lines of code. If there is any problem with adding the dependency, lmk and I can refactor without using the template.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@rhamilto: The label(s) /label ok-to-test cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?
In response to this:
/label ok-to-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@kmcfaul: This pull request references CONSOLE-4227 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Refactors multiselectdropdown to use Patternfly's
MultiTypeaheadSelecttemplate, which uses our newSelectcomponents, and brings the template package in. The main benefit of using this package is a lot of the filtering + keyboard logic and setup is handled internally by the template, saving about 250 lines of code. If there is any problem with adding the dependency, lmk and I can refactor without using the template.This also updates PF to 5.4 minus charts and topology, which will require additional changes to update.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
adding labels because this is debt
/label px-approved /label docs-approved
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kmcfaul, logonoff, rhamilto
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [rhamilto]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Checked on cluster launched against the pr, regression test about dropdown list on many pages passed. /label qe-approved
@kmcfaul: This pull request references CONSOLE-4227 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Refactors multiselectdropdown to use Patternfly's
MultiTypeaheadSelecttemplate, which uses our newSelectcomponents, and brings the template package in. The main benefit of using this package is a lot of the filtering + keyboard logic and setup is handled internally by the template, saving about 250 lines of code. If there is any problem with adding the dependency, lmk and I can refactor without using the template.This also updates PF to 5.4 minus charts and topology, which will require additional changes to update.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest-required
Remaining retests: 0 against base HEAD 2c069cbacb6854bd8dfa4cb1839c62fe1a0c1d5c and 2 for PR HEAD c2ec349be5921553840f41b04630508063545bb3 in total
@kmcfaul: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.19.0-202411080238.p0.g02adeca.assembly.stream.el9. All builds following this will include this PR.
