console icon indicating copy to clipboard operation
console copied to clipboard

[release-4.12] OCPBUGS-43639: Copy response code from proxied plugin requests

Open openshift-cherrypick-robot opened this issue 1 year ago • 9 comments

This is an automated cherry-pick of #13561

/assign TheRealJon

@openshift-cherrypick-robot: Jira Issue OCPBUGS-28788 has been cloned as Jira Issue OCPBUGS-43639. Will retitle bug to link to clone. /retitle [release-4.12] OCPBUGS-43639: Copy response code from proxied plugin requests

In response to this:

This is an automated cherry-pick of #13561

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 21 '24 20:10 openshift-ci-robot

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-43639, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #13561

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 21 '24 20:10 openshift-ci-robot

/label backport-risk-assessed

TheRealJon avatar Oct 21 '24 20:10 TheRealJon

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 22 '24 00:10 openshift-ci[bot]

/jira refresh

jhadvig avatar Oct 22 '24 11:10 jhadvig

@jhadvig: This pull request references Jira Issue OCPBUGS-43639, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 22 '24 11:10 openshift-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 22 '24 11:10 openshift-ci[bot]

/jira refresh

jhadvig avatar Oct 24 '24 10:10 jhadvig

@jhadvig: This pull request references Jira Issue OCPBUGS-43639, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-28788 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-28788 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact: /cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 24 '24 10:10 openshift-ci-robot

  1. Deploy console-demo-plugin and create a secure route
oc -n console-demo-plugin create route passthrough --service console-demo-plugin
  1. Run curl against plugin service
$ curl -k -D - -H "If-Modified-Since: Sun, 07 Jan 2024 14:45:30 GMT"  https://<plugin_route>/plugin-manifest.json
HTTP/1.1 304 Not Modified
  1. Enable console-demo-plugin and Run curl against console proxy
$ curl -k -D - -H "Cookie: <cookie>" -H "If-Modified-Since: Sun, 07 Jan 2024 14:45:30 GMT"  https://<console_route>/api/plugins/console-demo-plugin/plugin-manifest.json
HTTP/1.1 304 Not Modified

/label qe-approved /label cherry-pick-approved

yapei avatar Oct 30 '24 07:10 yapei

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-43639, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-28788 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-28788 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact: /cc @yapei

In response to this:

This is an automated cherry-pick of #13561

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 30 '24 07:10 openshift-ci-robot

@openshift-cherrypick-robot: Jira Issue OCPBUGS-43639: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43639 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #13561

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 30 '24 07:10 openshift-ci-robot

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.12.0-202410300801.p0.g7e1a504.assembly.stream.el8. All builds following this will include this PR.

openshift-bot avatar Oct 30 '24 08:10 openshift-bot

Fix included in accepted release 4.12.0-0.nightly-2024-10-30-135126

openshift-merge-robot avatar Oct 30 '24 20:10 openshift-merge-robot