OCPBUGS-23080: Add multiline support to template instantiation

[logonoff]

trafficstars

Fixes:

https://issues.redhat.com/browse/OCPBUGS-23080 #13317

Analysis / Root cause:

<input type="text /> does not support multiline

Solution Description:

Add a button to toggle between multiline and single line

Screen shots / Gifs for design review:

https://github.com/user-attachments/assets/1441c45a-9882-4aa7-b4da-f4222f0e572c

Unit test coverage report:

n/a

Test setup:

Download the example template posted in the jira ticket comments and apply it using oc create -f ./template.yaml

Browser conformance:

• [x] Chrome
• [x] Firefox
• [ ] Safari

[webknjaz]

Analysis / Root cause: <input type="text /> does not support multiline

@logonoff I think that's only a part of the cause. Have you checked if the result shows up as a secret? Your recording does not demonstrate looking up the saved value to verify that it's been saved the same.

IIRC, When I tried using DevTools to modify that input to a <textarea>, it was corrupting the input, making it single-line somewhere in the backend. Could you make sure that isn't happening?

[logonoff]

Analysis / Root cause: <input type="text /> does not support multiline

@logonoff I think that's only a part of the cause. Have you checked if the result shows up as a secret? Your recording does not demonstrate looking up the saved value to verify that it's been saved the same.

IIRC, When I tried using DevTools to modify that input to a <textarea>, it was corrupting the input, making it single-line somewhere in the backend. Could you make sure that isn't happening?

It seems to be working fine:

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-23080, which is invalid:

• expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-23080 #13317

Analysis / Root cause:

<input type="text /> does not support multiline

Solution Description:

Add a button to toggle between multiline and single line

Screen shots / Gifs for design review:

https://github.com/user-attachments/assets/1441c45a-9882-4aa7-b4da-f4222f0e572c

Unit test coverage report:

n/a

Test setup:

Download the example template posted in the jira ticket comments and apply it using oc create -f ./template.yaml

Browser conformance:

• [x] Chrome
• [x] Firefox
• [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/jira refresh

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-23080, which is invalid:

• expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/jira refresh

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-23080, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[webknjaz]

It seems to be working fine:

Thanks for checking. I'll make sure to ask the instance admins to upgrade once this is released and report back in case of any issues.

[logonoff]

/cc @vikram-raj for review

[openshift-ci[bot]]

@logonoff: GitHub didn't allow me to request PR reviews from the following users: for, review.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @vikram-raj for review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[logonoff]

needs UX review

/cc @Misjohns

[openshift-ci[bot]]

@logonoff: GitHub didn't allow me to request PR reviews from the following users: Misjohns.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

needs UX review

/cc @Misjohns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[logonoff]

needs UX review -- is there a cleaner design in patternfly that can be used for this patch?

/cc @nicolethoen

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-23080, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-23080 #13317

Analysis / Root cause:

<input type="text /> does not support multiline

Solution Description:

Add a button to toggle between multiline and single line

Screen shots / Gifs for design review:

https://github.com/user-attachments/assets/1441c45a-9882-4aa7-b4da-f4222f0e572c

Unit test coverage report:

n/a

Test setup:

Download the example template posted in the jira ticket comments and apply it using oc create -f ./template.yaml

Browser conformance:

• [x] Chrome
• [x] Firefox
• [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/retest

[openshift-ci[bot]]

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~frontend/OWNERS~~ [vikram-raj]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@logonoff: Jira Issue OCPBUGS-23080: All pull requests linked via external trackers have merged:

• openshift/console#14416

Jira Issue OCPBUGS-23080 has been moved to the MODIFIED state.

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-23080 #13317

Analysis / Root cause:

<input type="text /> does not support multiline

Solution Description:

Add a button to toggle between multiline and single line

Screen shots / Gifs for design review:

Unit test coverage report:

n/a

Test setup:

Download the example template posted in the jira ticket comments and apply it using oc create -f ./template.yaml

Browser conformance:

• [x] Chrome
• [x] Firefox
• [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/cherrypick release-4.17

[openshift-cherrypick-robot]

@logonoff: new pull request created: #14508

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.