console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-23924: Render TaskRun results even when failed

Open logonoff opened this issue 1 year ago • 6 comments
trafficstars

Fixes:

OCPBUGS-23924

Analysis / Root cause:

Render of TaskRun results was blocked if failed

Solution Description:

Render results regardless of failure

Screen shots / Gifs for design review:

https://github.com/user-attachments/assets/a21c12c3-767c-43a4-8f3d-afb21b776677

Unit test coverage report:

n/a

Test setup:

install pipeline operator and use the pipeline provided in the jira

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

logonoff avatar Oct 17 '24 18:10 logonoff

@logonoff: This pull request references Jira Issue OCPBUGS-23924, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:

OCPBUGS-23924

Analysis / Root cause:

Render of TaskRun results was blocked if failed

Solution Description:

Render results regardless of failure

Screen shots / Gifs for design review:

https://github.com/user-attachments/assets/a21c12c3-767c-43a4-8f3d-afb21b776677

Unit test coverage report:

n/a

Test setup:

install pipeline operator and use the pipeline provided in the jira

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 17 '24 18:10 openshift-ci-robot

/jira refresh

logonoff avatar Oct 17 '24 18:10 logonoff

@logonoff: This pull request references Jira Issue OCPBUGS-23924, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 17 '24 18:10 openshift-ci-robot

code review: /assign @lokanandaprabhu

logonoff avatar Oct 17 '24 18:10 logonoff

@logonoff: This pull request references Jira Issue OCPBUGS-23924, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Fixes:

OCPBUGS-23924

Analysis / Root cause:

Render of TaskRun results was blocked if failed

Solution Description:

Render results regardless of failure

Screen shots / Gifs for design review:

After:

image

Unit test coverage report:

n/a

Test setup:

install pipeline operator and use the pipeline provided in the jira

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 05 '24 16:12 openshift-ci-robot

/jira refresh

logonoff avatar Dec 05 '24 16:12 logonoff

@logonoff: This pull request references Jira Issue OCPBUGS-23924, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 05 '24 16:12 openshift-ci-robot

/retest

logonoff avatar Dec 06 '24 15:12 logonoff

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Dec 10 '24 09:12 openshift-ci[bot]

/label acknowledge-critical-fixes-only /retest

logonoff avatar Dec 10 '24 12:12 logonoff

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 0a0ce1a04969629a073827b96ebe404098d1ffa2 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Dec 10 '24 20:12 openshift-ci[bot]

@logonoff: Jira Issue OCPBUGS-23924: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23924 has been moved to the MODIFIED state.

In response to this:

Fixes:

OCPBUGS-23924

Analysis / Root cause:

Render of TaskRun results was blocked if failed

Solution Description:

Render results regardless of failure

Screen shots / Gifs for design review:

After:

image

Unit test coverage report:

n/a

Test setup:

install pipeline operator and use the pipeline provided in the jira

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 10 '24 22:12 openshift-ci-robot

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.19.0-202412110336.p0.g62e89ab.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Dec 11 '24 05:12 openshift-bot