console
console copied to clipboard
ODC-7698: Replace `CopyPipelineRunButton` with PF5 design
Fixes:
https://issues.redhat.com/browse/ODC-7698
Solution Description:
Remove react-copy-to-clipboard dep, remove CopyPipelineRunButton, and switch from a monaco-based design to the PatternFly-provided multiline design
I considered other options, such as rewriting the CopyPipelineRunButton using the PatternFly component; however, the presence of the textId prop in PF's ClipboardCopyButton highly implies that the intended design should accompany a node in the DOM with an id containing the text to be copied. However, the EditorField does not have an ID containing just the text, and copying from its parent would include line numbers.
Screen shots / Gifs for design review:
demo
https://github.com/user-attachments/assets/881f641c-6222-486b-a948-e13be739c9a3
Unit test coverage report:
n/a
Test setup:
n/a
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
@logonoff: This pull request references ODC-7698 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Fixes:
https://issues.redhat.com/browse/ODC-7698
Solution Description:
Remove
react-copy-to-clipboarddep, removeCopyPipelineRunButton, and switch from a monaco-based design to the PatternFly-provided multiline designScreen shots / Gifs for design review:
TMD
Unit test coverage report:
n/a
Test setup:
n/a
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references ODC-7698 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Fixes:
https://issues.redhat.com/browse/ODC-7698
Solution Description:
Remove
react-copy-to-clipboarddep, removeCopyPipelineRunButton, and switch from a monaco-based design to the PatternFly-provided multiline designScreen shots / Gifs for design review:
TBD
Unit test coverage report:
n/a
Test setup:
n/a
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references ODC-7698 which is a valid jira issue.
In response to this:
Fixes:
https://issues.redhat.com/browse/ODC-7698
Solution Description:
Remove
react-copy-to-clipboarddep, removeCopyPipelineRunButton, and switch from a monaco-based design to the PatternFly-provided multiline designI considered other options, such as rewriting the
CopyPipelineRunButtonusing the PatternFly component; however, the presence of thetextIdprop in PF'sClipboardCopyButtonhighly implies that the intended design should accompany a node in the DOM with an id containing the text to be copied. However, the EditorField does not have an ID, and copying from it would include line numbers.Screen shots / Gifs for design review:
TBD
Unit test coverage report:
n/a
Test setup:
n/a
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references ODC-7698 which is a valid jira issue.
In response to this:
Fixes:
https://issues.redhat.com/browse/ODC-7698
Solution Description:
Remove
react-copy-to-clipboarddep, removeCopyPipelineRunButton, and switch from a monaco-based design to the PatternFly-provided multiline designI considered other options, such as rewriting the
CopyPipelineRunButtonusing the PatternFly component; however, the presence of thetextIdprop in PF'sClipboardCopyButtonhighly implies that the intended design should accompany a node in the DOM with an id containing the text to be copied. However, theEditorFielddoes not have an ID containing just the text, and copying from its parent would include line numbers.Screen shots / Gifs for design review:
TBD
Unit test coverage report:
n/a
Test setup:
n/a
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references ODC-7698 which is a valid jira issue.
In response to this:
Fixes:
https://issues.redhat.com/browse/ODC-7698
Solution Description:
Remove
react-copy-to-clipboarddep, removeCopyPipelineRunButton, and switch from a monaco-based design to the PatternFly-provided multiline designI considered other options, such as rewriting the
CopyPipelineRunButtonusing the PatternFly component; however, the presence of thetextIdprop in PF'sClipboardCopyButtonhighly implies that the intended design should accompany a node in the DOM with an id containing the text to be copied. However, theEditorFielddoes not have an ID containing just the text, and copying from its parent would include line numbers.Screen shots / Gifs for design review:
demo
https://github.com/user-attachments/assets/881f641c-6222-486b-a948-e13be739c9a3
Unit test coverage report:
n/a
Test setup:
n/a
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
code review: /assign @vikram-raj
qe: /assign @sanketpathak
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: logonoff, vikram-raj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [vikram-raj]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/label docs-approved /label px-approved
/label qe-approved
@logonoff: This pull request references ODC-7698 which is a valid jira issue.
In response to this:
Fixes:
https://issues.redhat.com/browse/ODC-7698
Solution Description:
Remove
react-copy-to-clipboarddep, removeCopyPipelineRunButton, and switch from a monaco-based design to the PatternFly-provided multiline designI considered other options, such as rewriting the
CopyPipelineRunButtonusing the PatternFly component; however, the presence of thetextIdprop in PF'sClipboardCopyButtonhighly implies that the intended design should accompany a node in the DOM with an id containing the text to be copied. However, theEditorFielddoes not have an ID containing just the text, and copying from its parent would include line numbers.Screen shots / Gifs for design review:
demo
https://github.com/user-attachments/assets/881f641c-6222-486b-a948-e13be739c9a3
Unit test coverage report:
n/a
Test setup:
n/a
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/label acknowledge-critical-fixes-only
/retest
/retest
/retest
/retest-required
Remaining retests: 0 against base HEAD ea76ee699113d251e74be989e6ca9613e717db33 and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 1 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total
/retest
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total
/retest
/retest
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total