console icon indicating copy to clipboard operation
console copied to clipboard

ODC-7698: Replace `CopyPipelineRunButton` with PF5 design

Open logonoff opened this issue 1 year ago • 9 comments

Fixes:

https://issues.redhat.com/browse/ODC-7698

Solution Description:

Remove react-copy-to-clipboard dep, remove CopyPipelineRunButton, and switch from a monaco-based design to the PatternFly-provided multiline design

I considered other options, such as rewriting the CopyPipelineRunButton using the PatternFly component; however, the presence of the textId prop in PF's ClipboardCopyButton highly implies that the intended design should accompany a node in the DOM with an id containing the text to be copied. However, the EditorField does not have an ID containing just the text, and copying from its parent would include line numbers.

Screen shots / Gifs for design review:

demo

https://github.com/user-attachments/assets/881f641c-6222-486b-a948-e13be739c9a3

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

logonoff avatar Oct 17 '24 16:10 logonoff

@logonoff: This pull request references ODC-7698 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7698

Solution Description:

Remove react-copy-to-clipboard dep, remove CopyPipelineRunButton, and switch from a monaco-based design to the PatternFly-provided multiline design

Screen shots / Gifs for design review:

TMD

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 17 '24 16:10 openshift-ci-robot

@logonoff: This pull request references ODC-7698 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7698

Solution Description:

Remove react-copy-to-clipboard dep, remove CopyPipelineRunButton, and switch from a monaco-based design to the PatternFly-provided multiline design

Screen shots / Gifs for design review:

TBD

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 17 '24 16:10 openshift-ci-robot

@logonoff: This pull request references ODC-7698 which is a valid jira issue.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7698

Solution Description:

Remove react-copy-to-clipboard dep, remove CopyPipelineRunButton, and switch from a monaco-based design to the PatternFly-provided multiline design

I considered other options, such as rewriting the CopyPipelineRunButton using the PatternFly component; however, the presence of the textId prop in PF's ClipboardCopyButton highly implies that the intended design should accompany a node in the DOM with an id containing the text to be copied. However, the EditorField does not have an ID, and copying from it would include line numbers.

Screen shots / Gifs for design review:

TBD

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 17 '24 16:10 openshift-ci-robot

@logonoff: This pull request references ODC-7698 which is a valid jira issue.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7698

Solution Description:

Remove react-copy-to-clipboard dep, remove CopyPipelineRunButton, and switch from a monaco-based design to the PatternFly-provided multiline design

I considered other options, such as rewriting the CopyPipelineRunButton using the PatternFly component; however, the presence of the textId prop in PF's ClipboardCopyButton highly implies that the intended design should accompany a node in the DOM with an id containing the text to be copied. However, the EditorField does not have an ID containing just the text, and copying from its parent would include line numbers.

Screen shots / Gifs for design review:

TBD

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 17 '24 16:10 openshift-ci-robot

@logonoff: This pull request references ODC-7698 which is a valid jira issue.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7698

Solution Description:

Remove react-copy-to-clipboard dep, remove CopyPipelineRunButton, and switch from a monaco-based design to the PatternFly-provided multiline design

I considered other options, such as rewriting the CopyPipelineRunButton using the PatternFly component; however, the presence of the textId prop in PF's ClipboardCopyButton highly implies that the intended design should accompany a node in the DOM with an id containing the text to be copied. However, the EditorField does not have an ID containing just the text, and copying from its parent would include line numbers.

Screen shots / Gifs for design review:

demo

https://github.com/user-attachments/assets/881f641c-6222-486b-a948-e13be739c9a3

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 17 '24 16:10 openshift-ci-robot

code review: /assign @vikram-raj

qe: /assign @sanketpathak

logonoff avatar Oct 17 '24 17:10 logonoff

/retest

logonoff avatar Oct 17 '24 22:10 logonoff

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 05 '24 08:11 openshift-ci[bot]

/label docs-approved /label px-approved

vikram-raj avatar Nov 14 '24 07:11 vikram-raj

/label qe-approved

The-Anton avatar Nov 21 '24 16:11 The-Anton

@logonoff: This pull request references ODC-7698 which is a valid jira issue.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7698

Solution Description:

Remove react-copy-to-clipboard dep, remove CopyPipelineRunButton, and switch from a monaco-based design to the PatternFly-provided multiline design

I considered other options, such as rewriting the CopyPipelineRunButton using the PatternFly component; however, the presence of the textId prop in PF's ClipboardCopyButton highly implies that the intended design should accompany a node in the DOM with an id containing the text to be copied. However, the EditorField does not have an ID containing just the text, and copying from its parent would include line numbers.

Screen shots / Gifs for design review:

demo

https://github.com/user-attachments/assets/881f641c-6222-486b-a948-e13be739c9a3

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 21 '24 16:11 openshift-ci-robot

/label acknowledge-critical-fixes-only

logonoff avatar Nov 21 '24 16:11 logonoff

/retest

logonoff avatar Nov 21 '24 21:11 logonoff

/retest

logonoff avatar Nov 22 '24 01:11 logonoff

/retest

logonoff avatar Nov 22 '24 03:11 logonoff

/retest-required

Remaining retests: 0 against base HEAD ea76ee699113d251e74be989e6ca9613e717db33 and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total

openshift-ci-robot avatar Nov 22 '24 07:11 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 1 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total

openshift-ci-robot avatar Nov 22 '24 12:11 openshift-ci-robot

/retest

logonoff avatar Nov 22 '24 16:11 logonoff

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total

openshift-ci-robot avatar Nov 22 '24 20:11 openshift-ci-robot

/retest

logonoff avatar Nov 23 '24 00:11 logonoff

/retest

vikram-raj avatar Nov 25 '24 06:11 vikram-raj

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total

openshift-ci-robot avatar Nov 25 '24 10:11 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total

openshift-ci-robot avatar Nov 25 '24 15:11 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total

openshift-ci-robot avatar Nov 25 '24 18:11 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total

openshift-ci-robot avatar Nov 25 '24 23:11 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total

openshift-ci-robot avatar Nov 26 '24 14:11 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total

openshift-ci-robot avatar Nov 26 '24 18:11 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total

openshift-ci-robot avatar Nov 26 '24 22:11 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total

openshift-ci-robot avatar Nov 27 '24 01:11 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD d5b04512eae2df1d61780828035a9883ffa66421 in total

openshift-ci-robot avatar Nov 27 '24 05:11 openshift-ci-robot