console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-43462: Fix broken module references

Open logonoff opened this issue 1 year ago • 6 comments

Fixes:

https://issues.redhat.com/browse/OCPBUGS-43462

Analysis / Root cause:

Some references to files did not exist, e.g., NetworkPolicyListPage in console-app and functionsComponent in knative-plugin

Solution Description:

Fix the references or add the files

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

Browser conformance:

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari

logonoff avatar Oct 16 '24 19:10 logonoff

@logonoff: This pull request references Jira Issue OCPBUGS-43462, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-43462

Analysis / Root cause:

Some references to files did not exist, e.g., NetworkPolicyListPage in console-app and functionsComponent in knative-plugin

Solution Description:

Fix the references or add the files

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

Browser conformance:

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 16 '24 19:10 openshift-ci-robot

/jira refresh

logonoff avatar Oct 16 '24 19:10 logonoff

@logonoff: This pull request references Jira Issue OCPBUGS-43462, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 16 '24 19:10 openshift-ci-robot

code review: /assign @vikram-raj

logonoff avatar Oct 17 '24 17:10 logonoff

/label hacktoberfest-accepted

logonoff avatar Oct 29 '24 14:10 logonoff

@logonoff: The label(s) /label hacktoberfest-accepted cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label hacktoberfest-accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Oct 29 '24 14:10 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 04 '24 08:11 openshift-ci[bot]

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 04 '24 16:11 openshift-ci[bot]

@logonoff: Jira Issue OCPBUGS-43462: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43462 has been moved to the MODIFIED state.

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-43462

Analysis / Root cause:

Some references to files did not exist, e.g., NetworkPolicyListPage in console-app and functionsComponent in knative-plugin

Solution Description:

Fix the references or add the files

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

Browser conformance:

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 04 '24 16:11 openshift-ci-robot

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411041707.p0.g8b71aba.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Nov 04 '24 18:11 openshift-bot