console
console copied to clipboard
openshift
[WIP] CONSOLE-3905: (deps) upgrade to webpack 5
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded webpack related dependencies to latest version
- updated formik from 2.0.3 to 2.1.5 to fix build warning
- remove cache-loader, null-loader because they are deprecated
- updated react-dnd from 9.4.0 to 11.1.3 to fix build error
Reviewers and assignees:
n/aAdditional info:
[wip] I have some runtime errors, such as _TopologyPage__WEBPACK_IMPORTED_MODULE_5__ is undefined and can't access lexical declaration '__WEBPACK_DEFAULT_EXPORT__' before initialization, which seem to suggest there are some cyclical imports which I'm not really sure how to deal with
Screen shots / gifs / design review:
n/a
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded webpack and related dependencies to latest version - updated formik from 2.0.3 to 2.1.5 to fix build warning - remove cache-loader, null-loader because they are deprecatedReviewers and assignees:
n/aAdditional info:
n/aScreen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded webpack and related dependencies to latest version
- updated formik from 2.0.3 to 2.1.5 to fix build warning
- remove cache-loader, null-loader because they are deprecated
Reviewers and assignees:
n/aAdditional info:
n/aScreen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:
/test analyze/test backend/test e2e-gcp-console/test frontend/test images
The following commands are available to trigger optional jobs:
/test okd-scos-images
Use /test all to run the following jobs that were automatically triggered:
pull-ci-openshift-console-master-analyzepull-ci-openshift-console-master-backendpull-ci-openshift-console-master-e2e-gcp-consolepull-ci-openshift-console-master-frontendpull-ci-openshift-console-master-images
In response to this:
/retest e2e-gcp-console
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded webpack and related dependencies to latest version
- updated formik from 2.0.3 to 2.1.5 to fix build warning
- remove cache-loader, null-loader because they are deprecated
- updated react-dnd from 9.4.0 to 11.1.3 to fix build error
Reviewers and assignees:
n/aAdditional info:
n/aScreen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded webpack and related dependencies to latest version
- updated formik from 2.0.3 to 2.1.5 to fix build warning
- remove cache-loader, null-loader because they are deprecated
- updated react-dnd from 9.4.0 to 11.1.3 to fix build error
Reviewers and assignees:
n/aAdditional info:
[wip] I have some runtime errors, such as
_TopologyPage__WEBPACK_IMPORTED_MODULE_5__ is undefinedandcan't access lexical declaration '__WEBPACK_DEFAULT_EXPORT__' before initialization, which seem to suggest there are some cyclical imports which I'm not really sure how to deal withScreen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded webpack related dependencies to latest version
- upgraded webpack to 5.75 to match plugins
- updated formik from 2.0.3 to 2.1.5 to fix build warning
- remove cache-loader, null-loader because they are deprecated
- updated react-dnd from 9.4.0 to 11.1.3 to fix build error
Reviewers and assignees:
n/aAdditional info:
[wip] I have some runtime errors, such as
_TopologyPage__WEBPACK_IMPORTED_MODULE_5__ is undefinedandcan't access lexical declaration '__WEBPACK_DEFAULT_EXPORT__' before initialization, which seem to suggest there are some cyclical imports which I'm not really sure how to deal withScreen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded webpack related dependencies to latest version
- updated formik from 2.0.3 to 2.1.5 to fix build warning
- remove cache-loader, null-loader because they are deprecated
- updated react-dnd from 9.4.0 to 11.1.3 to fix build error
Reviewers and assignees:
n/aAdditional info:
[wip] I have some runtime errors, such as
_TopologyPage__WEBPACK_IMPORTED_MODULE_5__ is undefinedandcan't access lexical declaration '__WEBPACK_DEFAULT_EXPORT__' before initialization, which seem to suggest there are some cyclical imports which I'm not really sure how to deal withScreen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded webpack related dependencies to latest version
- updated formik from 2.0.3 to 2.1.5 to fix build warning
- remove cache-loader, null-loader because they are deprecated
- updated react-dnd from 9.4.0 to 11.1.3 to fix build error
Reviewers and assignees:
n/aAdditional info:
Screen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded webpack related dependencies to latest version
- updated formik from 2.0.3 to 2.1.5 to fix build warning
- remove cache-loader, null-loader because they are deprecated
- updated react-dnd from 9.4.0 to 11.1.3 to fix build error
Reviewers and assignees:
n/aAdditional info:
n/aScreen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded webpack related dependencies to latest version
- updated formik from 2.0.3 to 2.1.5 to fix build warning
- remove cache-loader, null-loader because they are deprecated
- updated react-dnd from 9.4.0 to 11.1.3 to fix build error
Reviewers and assignees:
n/aScreen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded webpack related dependencies to latest version
- updated formik from 2.0.3 to 2.1.5 to fix build warning
- remove cache-loader, null-loader because they are deprecated
- updated react-dnd from 9.4.0 to 11.1.3 to fix build error
Reviewers and assignees:
Test cases:
- Does
@console/internal/file-inputstill work as expected?- Are there any regressions with
formikorreact-dnd?- Do all the Monaco YAML language server features work?
- Does everything else feel the exact same?
Additional info:
n/aScreen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded webpack related dependencies to latest version
- updated formik from 2.0.3 to 2.1.5 to fix build warning
- remove cache-loader, null-loader because they are deprecated
- updated react-dnd from 9.4.0 to 11.1.3 to fix build error
Reviewers and assignees:
n/a
Test cases:
- Does
@console/internal/file-inputstill work as expected?- Are there any regressions with
formikorreact-dnd?- Do all the Monaco YAML language server features work?
- Does everything else feel the exact same?
Additional info:
n/aScreen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded webpack related dependencies to latest version
- updated formik from 2.0.3 to 2.1.5 to fix build warning
- remove cache-loader, null-loader because they are deprecated
- updated react-dnd from 9.4.0 to 11.1.3 to fix build error
- switched ts-loader to esbuild-loader for performance
Reviewers and assignees:
n/a
Test cases:
- Does
@console/internal/file-inputstill work as expected?- Are there any regressions with
formikorreact-dnd?- Do all the Monaco YAML language server features work?
- Does everything else feel the exact same?
Additional info:
n/aScreen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded
webpackrelated dependencies to latest version- updated
formikfrom 2.0.3 to 2.1.5 to fix build warning- remove
cache-loader,null-loaderbecause they are deprecated- updated
react-dndfrom 9.4.0 to 11.1.3 to fix build error- switched
ts-loadertoesbuild-loaderfor performance- switch
webpack-virtual-moduleswithval-loaderto fix build warning (and for easier transition to rspack, since it supports most loader APIs)Reviewers and assignees:
n/a
Test cases:
- Does
@console/internal/file-inputstill work as expected?- Are there any regressions with
formikorreact-dnd?- Do all the Monaco YAML language server features work?
- Does everything else feel the exact same?
Additional info:
n/a
Screen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Thanks, @logonoff. Fantastic work.
Do we know if there are any downstream impacts to plugins with this change? Would be good to have @vojtechszocs review at least the plugin related bits.
From some preliminary testing I couldn't find anything: monitoring-plugin seems to be working fine, including the promql input and charts
adding labels as this is tech debt
/label px-approved /label docs-approved
For QE review:
/assign @yapei or /assign @sanketpathak
whoever has the time
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded
webpackrelated dependencies to latest version- updated
formikfrom 2.0.3 to 2.1.5 to fix build warning- remove
cache-loader,null-loaderbecause they are deprecated- updated
react-dndfrom 9.4.0 to 11.1.3 to fix build error- switched
ts-loadertoesbuild-loaderfor performance- switch
webpack-virtual-moduleswithval-loaderto fix build warning (and for easier transition to rspack, since it supports most loader APIs)Reviewers and assignees:
n/a
Test cases:
- Does
@console/internal/file-inputstill work as expected?- Are there any regressions with any usages of
formikorreact-dnd?- Do all the Monaco YAML language server features work?
- Does everything else work the exact same?
- Do all dynamic and static plugins work as expected?
Additional info:
n/a
Screen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded
webpackrelated dependencies to latest version- updated
formikfrom 2.0.3 to 2.1.5 to fix build warning- remove
cache-loader,null-loaderbecause they are deprecated- updated
react-dndfrom 9.4.0 to 11.1.3 to fix build error- switched
ts-loadertoesbuild-loaderfor performance- switch
webpack-virtual-moduleswithval-loaderto fix build warning (and for easier transition to rspack, since it supports most loader APIs)Reviewers and assignees:
n/a
Test cases:
- Does
@console/internal/file-inputstill work as expected?- Are there any regressions with any usages of
formikorreact-dnd?- Do all the Monaco YAML language server features work?
- Do all dynamic and static plugins work as expected?
- Does everything else work the exact same?
Additional info:
n/a
Screen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded
webpackrelated dependencies to latest version- updated
formikfrom 2.0.3 to 2.1.5 to fix build warning- remove
cache-loader,null-loaderbecause they are deprecated- updated
react-dndfrom 9.4.0 to 11.1.3 to fix build error- switched
ts-loadertoesbuild-loaderfor performance- switch
webpack-virtual-moduleswithval-loaderto fix build warning (and for easier transition to rspack, since it supports most loader APIs)Reviewers and assignees:
n/a
Test cases:
- Does
@console/internal/file-inputstill work as expected?- Are there any regressions with
formikorreact-dnd?- Do all the Monaco YAML language server features work?
- Do all dynamic and static plugins work as expected?
- Does everything else work the same?
Additional info:
n/a
Screen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Ran some regression testings based on the listed scenarios in Test cases:
no issues found
/label qe-approved
@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.
In response to this:
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/CONSOLE-3905
Solution description
- upgraded
webpackrelated dependencies to latest version- updated
formikfrom 2.0.3 to 2.1.5 to fix build warning- remove
cache-loader,null-loaderbecause they are deprecated- updated
react-dndfrom 9.4.0 to 11.1.3 to fix build error- switched
ts-loadertoesbuild-loaderfor performance- switch
webpack-virtual-moduleswithval-loaderto fix build warning (and for easier transition to rspack, since it supports most loader APIs)Reviewers and assignees:
n/a
Test cases:
- Does
@console/internal/file-inputstill work as expected?- Are there any regressions with
formikorreact-dnd?- Do all the Monaco YAML language server features work?
- Do all dynamic and static plugins work as expected?
- Does everything else work the same?
Additional info:
n/a
Screen shots / gifs / design review:
n/a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Jira ticket for throwing warnings on guessModuleFilePath usage: https://issues.redhat.com/browse/CONSOLE-4382
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: logonoff, vojtechszocs
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [vojtechszocs]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@logonoff:
In response to this:
/honk
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.