CONSOLE-4286: Remove unnecessary Intl type def

[logonoff]

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-4286

Solution description

There is a TODO in frontend/@types/console/index.d.ts:

// TODO: Remove when upgrading to TypeScript 4.1.2+, which has a type for ListFormat and RelativeTimeFormat.
declare namespace Intl {
	// omitted
}

We are currently using typescript 4.5.5 which is is newer than typescript 4.1.2, so this code is safe to remove

Reviewers and assignees:

n/a

Additional info:

n/a

Screen shots / gifs / design review:

n/a

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-4286 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

Features: https://issues.redhat.com/browse/CONSOLE-4286

Solution description

There is a TODO in frontend/@types/console/index.d.ts:

// TODO: Remove when upgrading to TypeScript 4.1.2+, which has a type for ListFormat and RelativeTimeFormat.
declare namespace Intl {
  // omitted
}

We are currently using typescript 4.5.5 which is is newer than typescript 4.1.2, so this code is safe to remove

Reviewers and assignees:

n/a

Additional info:

n/a

Screen shots / gifs / design review:

n/a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-4286 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-4286

Solution description

There is a TODO in frontend/@types/console/index.d.ts:

// TODO: Remove when upgrading to TypeScript 4.1.2+, which has a type for ListFormat and RelativeTimeFormat.
declare namespace Intl {
  // omitted
}

We are currently using typescript 4.5.5 which is is newer than typescript 4.1.2, so this code is safe to remove

Reviewers and assignees:

n/a

Additional info:

n/a

Screen shots / gifs / design review:

n/a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-4286 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

[https://issues.redhat.com/browse/CONSOLE-4286](https://issues.redhat.com/browse/CONSOLE-4286)

Solution description

There is a TODO in frontend/@types/console/index.d.ts:

// TODO: Remove when upgrading to TypeScript 4.1.2+, which has a type for ListFormat and RelativeTimeFormat.
declare namespace Intl {
  // omitted
}

We are currently using typescript 4.5.5 which is is newer than typescript 4.1.2, so this code is safe to remove

Reviewers and assignees:

n/a

Additional info:

n/a

Screen shots / gifs / design review:

n/a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-4286 which is a valid jira issue.

In response to this:

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-4286

Solution description

There is a TODO in frontend/@types/console/index.d.ts:

// TODO: Remove when upgrading to TypeScript 4.1.2+, which has a type for ListFormat and RelativeTimeFormat.
declare namespace Intl {
  // omitted
}

We are currently using typescript 4.5.5 which is is newer than typescript 4.1.2, so this code is safe to remove

Reviewers and assignees:

n/a

Additional info:

n/a

Screen shots / gifs / design review:

n/a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-45835, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-4286

Solution description

There is a TODO in frontend/@types/console/index.d.ts:

// TODO: Remove when upgrading to TypeScript 4.1.2+, which has a type for ListFormat and RelativeTimeFormat.
declare namespace Intl {
  // omitted
}

We are currently using typescript 4.5.5 which is is newer than typescript 4.1.2, so this code is safe to remove

Reviewers and assignees:

n/a

Additional info:

n/a

Screen shots / gifs / design review:

n/a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff Once this PR has been reviewed and has the lgtm label, please assign cyril-ui-developer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[logonoff]

/jira refresh

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-45835, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/close

This will have to be addressed after typescript is upgraded to 4.7.4

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-45835. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-4286

Solution description

There is a TODO in frontend/@types/console/index.d.ts:

// TODO: Remove when upgrading to TypeScript 4.1.2+, which has a type for ListFormat and RelativeTimeFormat.
declare namespace Intl {
  // omitted
}

We are currently using typescript 4.5.5 which is is newer than typescript 4.1.2, so this code is safe to remove

Reviewers and assignees:

n/a

Additional info:

n/a

Screen shots / gifs / design review:

n/a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci[bot]]

@logonoff: Closed this PR.

In response to this:

/close

This will have to be addressed after typescript is upgraded to 4.7.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci[bot]]

@logonoff: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/frontend	b9cfbd199ea771c1075c840461926e5b227f5d94	link	true	/test frontend
ci/prow/e2e-gcp-console	b9cfbd199ea771c1075c840461926e5b227f5d94	link	true	/test e2e-gcp-console
ci/prow/images	b9cfbd199ea771c1075c840461926e5b227f5d94	link	true	/test images
ci/prow/backend	b9cfbd199ea771c1075c840461926e5b227f5d94	link	true	/test backend
ci/prow/analyze	b9cfbd199ea771c1075c840461926e5b227f5d94	link	true	/test analyze

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.