console
console copied to clipboard
openshift
OCPBUGS-42298: Remove ClusterTask dependency in console from Pipelines 1.17
Fixes: https://issues.redhat.com/browse/OCPBUGS-42298
Solution Description: ClusterTask has been deprecated and will be removed in Pipelines Operator 1.17
So to support this,
- Removed ClusterTask list page in search menu if Pipelines Operator >= 1.17
- Removed ClusterTask list page tab in Tasks navigation menu if Pipelines Operator >= 1.17
- ClusterTask is removed from quick search in Pipelines builder if Pipelines Operator >= 1.17
Unit test coverage report:
Test setup:
1. Install Pipelines operator
2. If Pipeline operator is 1.16 or lower, then it should work as existing behaviour, used should see ClusterTask in Task navigation menu and Pipeline builder page
3. Since Pipelines 1.17 is not installed, for testing purpose, make the below changes to test in `useIsPipelineOperatorVersion_1_17` function in `pipeline-operator.ts` file,
const IS_PIPELINE_OPERATOR_VERSION_1_17 =
operatorVersion?.major === 1 && operatorVersion?.minor >= 17;
to
const IS_PIPELINE_OPERATOR_VERSION_1_17 =
operatorVersion?.major === 1 && operatorVersion?.minor >= 15;
Browser conformance:
- [x] Chrome
- [ ] Firefox
- [ ] Safari
- [ ] Edge
@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-42298, which is invalid:
- expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.15.z" instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
/hold
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-42298, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.18.0) matches configured target version for branch (4.18.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @sanketpathak
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest-required
Remaining retests: 0 against base HEAD d5f70f8a9dc59abba88babdd0a10b12c0f7c14ba and 2 for PR HEAD 5df818d1f0bd8c2e085cd8a9d29fbc161f2083ee in total
/retest-required
Remaining retests: 0 against base HEAD ee60f4920e573350e4f017a63f41933c70ac8b9a and 2 for PR HEAD 5df818d1f0bd8c2e085cd8a9d29fbc161f2083ee in total
/retest-required
Remaining retests: 0 against base HEAD cd12b6b3082567a603b216a3ed35c5e5008aa040 and 2 for PR HEAD 5df818d1f0bd8c2e085cd8a9d29fbc161f2083ee in total
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: logonoff, lokanandaprabhu, vikram-raj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/pipelines-plugin/OWNERS~~ [lokanandaprabhu,vikram-raj]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/retest-required
Remaining retests: 0 against base HEAD bb0a645f1319f0171d7891f20a35737080810d0a and 2 for PR HEAD 3b67c03add665086b77fd8fbe0eee7d89ca522f9 in total
@lokanandaprabhu: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@lokanandaprabhu: Jira Issue OCPBUGS-42298: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-42298 has been moved to the MODIFIED state.
In response to this:
Fixes: https://issues.redhat.com/browse/OCPBUGS-42298
Solution Description: ClusterTask has been deprecated and will be removed in Pipelines Operator 1.17
So to support this,
- Removed ClusterTask list page in search menu if Pipelines Operator >= 1.17
- Removed ClusterTask list page tab in Tasks navigation menu if Pipelines Operator >= 1.17
- ClusterTask is removed from quick search in Pipelines builder if Pipelines Operator >= 1.17
Unit test coverage report:
Test setup:
- Install Pipelines operator
- If Pipeline operator is 1.16 or lower, then it should work as existing behaviour, used should see ClusterTask in Task navigation menu and Pipeline builder page
- Since Pipelines 1.17 is not installed, for testing purpose, make the below changes to test in
useIsPipelineOperatorVersion_1_17function inpipeline-operator.tsfile,const IS_PIPELINE_OPERATOR_VERSION_1_17 = operatorVersion?.major === 1 && operatorVersion?.minor >= 17;to
const IS_PIPELINE_OPERATOR_VERSION_1_17 = operatorVersion?.major === 1 && operatorVersion?.minor >= 15;Browser conformance:
- [x] Chrome
- [ ] Firefox
- [ ] Safari
- [ ] Edge
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@lokanandaprabhu: #14349 failed to apply on top of branch "release-4.17":
Applying: Removing ClusterTask dependecny since it is deprecated from Pipelines 1.17
Using index info to reconstruct a base tree...
M frontend/packages/pipelines-plugin/console-extensions.json
M frontend/packages/pipelines-plugin/src/components/pipelines-index.ts
M frontend/packages/pipelines-plugin/src/components/pipelines/const.ts
M frontend/packages/pipelines-plugin/src/components/pipelines/utils/pipeline-operator.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/pipelines-plugin/src/components/pipelines/utils/pipeline-operator.ts
CONFLICT (content): Merge conflict in frontend/packages/pipelines-plugin/src/components/pipelines/utils/pipeline-operator.ts
Auto-merging frontend/packages/pipelines-plugin/src/components/pipelines/const.ts
CONFLICT (content): Merge conflict in frontend/packages/pipelines-plugin/src/components/pipelines/const.ts
Auto-merging frontend/packages/pipelines-plugin/src/components/pipelines-index.ts
CONFLICT (content): Merge conflict in frontend/packages/pipelines-plugin/src/components/pipelines-index.ts
Removing frontend/packages/pipelines-plugin/integration-tests/testData/pipelines-workspaces/pipeline-with-workspace.yaml
Removing frontend/packages/pipelines-plugin/integration-tests/testData/pipelines-workspaces/pipeline-task-tkn.yaml
Auto-merging frontend/packages/pipelines-plugin/console-extensions.json
CONFLICT (content): Merge conflict in frontend/packages/pipelines-plugin/console-extensions.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Removing ClusterTask dependecny since it is deprecated from Pipelines 1.17
In response to this:
/cherrypick release-4.17
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[ART PR BUILD NOTIFIER]
Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411041337.p0.gbcd8cbd.assembly.stream.el9. All builds following this will include this PR.
