console icon indicating copy to clipboard operation
console copied to clipboard

[WIP] OCPBUGS-41826, OCPBUGS-41676: upgrade axe-core and cypress-axe

Open rhamilto opened this issue 1 year ago • 5 comments

Blocked by https://github.com/patternfly/patternfly-react/issues/11023

rhamilto avatar Sep 19 '24 13:09 rhamilto

@rhamilto: This pull request references Jira Issue OCPBUGS-41826, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 19 '24 13:09 openshift-ci-robot

/retitle [WIP] OCPBUGS-41826, OCPBUGS-41676: upgrade axe-core and cypress-axe

logonoff avatar Oct 18 '24 16:10 logonoff

@rhamilto: This pull request references Jira Issue OCPBUGS-41826, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-41676, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Blocked by https://github.com/patternfly/patternfly-react/issues/11023

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 18 '24 16:10 openshift-ci-robot

@rhamilto: This pull request references Jira Issue OCPBUGS-41826, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-41676, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Includes changes from https://github.com/openshift/console/pull/14503, which should merge first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 06 '24 15:12 openshift-ci-robot

/retest

rhamilto avatar Dec 06 '24 19:12 rhamilto

/retest

rhamilto avatar Dec 08 '24 13:12 rhamilto

/retest

rhamilto avatar Dec 08 '24 20:12 rhamilto

/retest

rhamilto avatar Dec 10 '24 18:12 rhamilto

/test okd-scos-e2e-aws-ovn

rhamilto avatar Dec 11 '24 13:12 rhamilto

@rhamilto: This pull request references Jira Issue OCPBUGS-41826, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-41676, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 11 '24 13:12 openshift-ci-robot

/jira refresh

rhamilto avatar Dec 11 '24 13:12 rhamilto

@rhamilto: This pull request references Jira Issue OCPBUGS-41826, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

This pull request references Jira Issue OCPBUGS-41676, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 11 '24 13:12 openshift-ci-robot

/jira refresh

rhamilto avatar Dec 11 '24 13:12 rhamilto

@rhamilto: This pull request references Jira Issue OCPBUGS-41826, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

This pull request references Jira Issue OCPBUGS-41676, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 11 '24 13:12 openshift-ci-robot

/assign @logonoff

rhamilto avatar Dec 11 '24 13:12 rhamilto

There are a few rules in https://github.com/openshift/console/blob/master/frontend/packages/integration-tests-cypress/support/a11y.ts that were disabled to give the PF team time, but it has been 4 years -- can you check if they can be re-enabled?

That's a great suggestion, but I think it should be done as a follow-on so as not to block this fix and those that depend on it.

rhamilto avatar Dec 11 '24 13:12 rhamilto

There are a few rules in https://github.com/openshift/console/blob/master/frontend/packages/integration-tests-cypress/support/a11y.ts that were disabled to give the PF team time, but it has been 4 years -- can you check if they can be re-enabled?

That's a great suggestion, but I think it should be done as a follow-on so as not to block this fix and those that depend on it.

Opened a bug to track: https://issues.redhat.com/browse/OCPBUGS-46050

rhamilto avatar Dec 11 '24 14:12 rhamilto

/test okd-scos-e2e-aws-ovn

rhamilto avatar Dec 11 '24 15:12 rhamilto

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Dec 11 '24 15:12 openshift-ci[bot]

@rhamilto: This pull request references Jira Issue OCPBUGS-41826, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-41676, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 11 '24 19:12 openshift-ci-robot

@rhamilto: This pull request references Jira Issue OCPBUGS-41826. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

This pull request references Jira Issue OCPBUGS-41676. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 11 '24 19:12 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD 79f63d21312245010ce93d3b4225dab20c769c4e and 2 for PR HEAD f332e946b2554ca45a251c5269f0f95b9aaf818f in total

openshift-ci-robot avatar Dec 12 '24 00:12 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD 79f63d21312245010ce93d3b4225dab20c769c4e and 2 for PR HEAD f332e946b2554ca45a251c5269f0f95b9aaf818f in total

openshift-ci-robot avatar Dec 12 '24 05:12 openshift-ci-robot

/retest

rhamilto avatar Dec 12 '24 12:12 rhamilto

/retest-required

Remaining retests: 0 against base HEAD 79f63d21312245010ce93d3b4225dab20c769c4e and 2 for PR HEAD f332e946b2554ca45a251c5269f0f95b9aaf818f in total

openshift-ci-robot avatar Dec 12 '24 18:12 openshift-ci-robot

/retest

rhamilto avatar Dec 12 '24 19:12 rhamilto

/retest-required

Remaining retests: 0 against base HEAD 6105df92b2b0a092d00f07de4445a53fc5e9d04a and 2 for PR HEAD f332e946b2554ca45a251c5269f0f95b9aaf818f in total

openshift-ci-robot avatar Dec 13 '24 04:12 openshift-ci-robot

@rhamilto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn f332e946b2554ca45a251c5269f0f95b9aaf818f link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Dec 13 '24 09:12 openshift-ci[bot]

@rhamilto: Jira Issue OCPBUGS-41826: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41826 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-41676: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41676 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 13 '24 09:12 openshift-ci-robot

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.19.0-202412131335.p0.g41fae99.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Dec 13 '24 14:12 openshift-bot