console icon indicating copy to clipboard operation
console copied to clipboard

[release-4.17] OCPBUGS-41672: Update vendor imports to include all PatternFly components

Open openshift-cherrypick-robot opened this issue 1 year ago • 14 comments

This is an automated cherry-pick of #14246

/assign jhadvig

@openshift-cherrypick-robot: Jira Issue OCPBUGS-38845 has been cloned as Jira Issue OCPBUGS-41672. Will retitle bug to link to clone. /retitle [release-4.17] OCPBUGS-41672: Update vendor imports to include all PatternFly components

In response to this:

This is an automated cherry-pick of #14246

/assign jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 10 '24 17:09 openshift-ci-robot

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-41672, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-38845 to target a version in 4.18.0, but it targets "4.18" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #14246

/assign jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 10 '24 17:09 openshift-ci-robot

Tested on cluster launched against the pr, install console-plugin-template plugin(include Banner and JumpLinks on page), the banner and links show correctly. /label qe-approved /label cherry-pick-approved

yanpzhan avatar Sep 13 '24 11:09 yanpzhan

/jira refresh

yanpzhan avatar Sep 14 '24 01:09 yanpzhan

@yanpzhan: This pull request references Jira Issue OCPBUGS-41672, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-38845 to target a version in 4.18.0, but it targets "4.18" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 14 '24 01:09 openshift-ci-robot

/jira refresh

yanpzhan avatar Sep 14 '24 03:09 yanpzhan

@yanpzhan: This pull request references Jira Issue OCPBUGS-41672, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-38845 to target a version in 4.18.0, but it targets "4.18" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 14 '24 03:09 openshift-ci-robot

/jira refresh

yanpzhan avatar Sep 14 '24 03:09 yanpzhan

@yanpzhan: This pull request references Jira Issue OCPBUGS-41672, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 14 '24 03:09 openshift-ci-robot

/jira refresh

jhadvig avatar Sep 16 '24 10:09 jhadvig

@jhadvig: This pull request references Jira Issue OCPBUGS-41672, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-38845 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-38845 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

Requesting review from QA contact: /cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 16 '24 10:09 openshift-ci-robot

/lgtm

jhadvig avatar Sep 16 '24 10:09 jhadvig

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 16 '24 10:09 openshift-ci[bot]

Hello, we're looking forward on having this merged for 4.17, what's the status on this one @jhadvig ?

lavocatt avatar Dec 05 '24 14:12 lavocatt

@jhadvig is there a reason this has not merged? I see the issue is fixed on 4.16.24, but it persists in 4.17.7.

KevinFCormier avatar Dec 06 '24 21:12 KevinFCormier

/label backport-risk-assessed

sg00dwin avatar Jan 06 '25 15:01 sg00dwin

@sg00dwin: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jan 06 '25 15:01 openshift-ci[bot]

/cherry-pick release-4.16 /cherry-pick release-4.15

sg00dwin avatar Jan 06 '25 16:01 sg00dwin

@sg00dwin: once the present PR merges, I will cherry-pick it on top of release-4.15, release-4.16 in new PRs and assign them to you.

In response to this:

/cherry-pick release-4.16 /cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/label backport-risk-assessed

jhadvig avatar Jan 06 '25 17:01 jhadvig

/retest-required

Remaining retests: 0 against base HEAD 8c4683e6e6cdce583a776fdb0e25aacd81793e8f and 2 for PR HEAD b7de1cf4f6c94a92c2e56fe9700db79117f05c1d in total

openshift-ci-robot avatar Jan 07 '25 00:01 openshift-ci-robot

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jan 07 '25 04:01 openshift-ci[bot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-41672: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41672 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #14246

/assign jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jan 07 '25 04:01 openshift-ci-robot

@sg00dwin: new pull request could not be created: failed to create pull request against openshift/console#release-4.16 from head openshift-cherrypick-robot:cherry-pick-14272-to-release-4.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.16 and openshift-cherrypick-robot:cherry-pick-14272-to-release-4.16"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-4.16 /cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sg00dwin: new pull request created: #14662

In response to this:

/cherry-pick release-4.16 /cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/cherry-pick release-4.16

sg00dwin avatar Jan 07 '25 13:01 sg00dwin

/cherrypick release-4.16

rhamilto avatar Jan 07 '25 13:01 rhamilto

@sg00dwin: new pull request could not be created: failed to create pull request against openshift/console#release-4.16 from head openshift-cherrypick-robot:cherry-pick-14272-to-release-4.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.16 and openshift-cherrypick-robot:cherry-pick-14272-to-release-4.16"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhamilto: new pull request could not be created: failed to create pull request against openshift/console#release-4.16 from head openshift-cherrypick-robot:cherry-pick-14272-to-release-4.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.16 and openshift-cherrypick-robot:cherry-pick-14272-to-release-4.16"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/jira refresh

sg00dwin avatar Jan 07 '25 16:01 sg00dwin